AkkomaGang/akkoma
AkkomaGang/akkoma
15
66
Fork 94
Code Issues 180 Pull requests 28 Projects 2 Releases 14 Packages Wiki Activity

URL encode remote emoji pack names #362

Merged
floatingghost merged 1 commit from :fix/emojipack-url into develop 2023-01-15 18:14:04 +00:00
Conversation 1 Commits 1 Files changed 5 +52 -8
Ghost commented 2022-12-10 20:24:46 +00:00
First-time contributor
Copy link

fix #246

fix #246
🎉 2
Ghost changed title from URL encode remote emoji pack names to WIP: URL encode remote emoji pack names 2022-12-10 22:55:01 +00:00
Ghost force-pushed fix/emojipack-url from f5e2e40b59 to f8cd122871 2022-12-10 23:31:22 +00:00 Compare
Ghost changed title from WIP: URL encode remote emoji pack names to URL encode remote emoji pack names 2022-12-10 23:31:28 +00:00
floatingghost requested changes 2022-12-14 02:58:13 +00:00
floatingghost left a comment
Owner
Copy link

whilst the change is ok, this 100% needs a test to assert it works

whilst the change is ok, this 100% needs a test to assert it works
floatingghost added the
needs tests
 label 2022-12-14 10:48:51 +00:00
Ghost force-pushed fix/emojipack-url from f8cd122871 to ec69c28fc8 2022-12-30 09:55:38 +00:00 Compare
Ghost force-pushed fix/emojipack-url from ec69c28fc8 to f9f8bbc95b 2022-12-30 10:00:48 +00:00 Compare
Ghost requested review from floatingghost 2022-12-30 10:10:11 +00:00
floatingghost commented 2023-01-15 18:13:59 +00:00
Owner
Copy link

yep, this looks much better now

thanks!

yep, this looks much better now thanks!
floatingghost merged commit 20cd8a0fc4 into develop 2023-01-15 18:14:04 +00:00
floatingghost deleted branch fix/emojipack-url 2023-01-15 18:14:04 +00:00
rat referenced this pull request from a commit 2024-02-25 20:33:31 +00:00
URL encode remote emoji pack names (#362)
Sign in to join this conversation.
Reviewers
No reviewers
floatingghost
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#362
No description provided.
Delete branch ":fix/emojipack-url"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?