AkkomaGang/akkoma
AkkomaGang
/
akkoma
12
63
Fork 83
Code Issues 170 Pull Requests 17 Packages Projects 2 Releases 12 Wiki Activity

Correct og:description tag in static-fe #373

Merged
floatingghost merged 1 commits from nbsp/akkoma:fix/og-description into develop 2023-01-15 18:15:21 +00:00
Conversation 4 Commits 1 Files Changed 1 +1 -1
nbsp commented 2022-12-14 18:37:47 +00:00
Contributor
Copy Link

fix #365

why pleroma :crie:

fix #365 why pleroma :crie:
floatingghost commented 2022-12-14 20:56:52 +00:00
Owner
Copy Link

breaks tests

you're not in frontend land anymore, make sure tests pass, and in most cases you'll want to add tests - "works for me" isn't enough here

breaks tests you're not in frontend land anymore, make sure tests pass, and in most cases you'll want to add tests - "works for me" isn't enough here
floatingghost added the
needs tests
 label 2022-12-14 20:57:21 +00:00
nbsp commented 2022-12-14 21:02:27 +00:00
Author
Contributor
Copy Link

istg it's only on the times i forget to run tests that the tests fail

istg it's only on the times i forget to run tests that the tests fail
nbsp force-pushed fix/og-description from 072d38f4a9 to 1d884fd914 2022-12-30 05:16:17 +00:00 Compare
nbsp commented 2022-12-30 05:16:37 +00:00
Author
Contributor
Copy Link

fixed! this time i ran tests 🥴

fixed! this time i ran tests 🥴
floatingghost commented 2023-01-15 18:14:41 +00:00
Owner
Copy Link

so you did

this is ok now, thank~

so you did this is ok now, thank~
floatingghost merged commit 63ce25f32c into develop 2023-01-15 18:15:21 +00:00
floatingghost deleted branch fix/og-description 2023-01-15 18:15:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#373
No description provided.
Delete Branch "nbsp/akkoma:fix/og-description"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?