AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 177 Pull requests 25 Projects 2 Releases 14 Packages Wiki Activity

Use any custom WebFinger domain for page metadata #442

Closed
hufman wants to merge 0 commits from hufman/akkoma:metadata_webfinger into develop
pull from: hufman/akkoma:metadata_webfinger
merge into: AkkomaGang:develop
Conversation 11 Commits - Files changed -
hufman commented 2023-01-23 02:30:55 +00:00
First-time contributor
Copy link

Updates the og:title and twitter:title properties to use the WebFinger domain instead of the server hostname, which should make url previews show up a little more correctly in certain applications.

Updates the og:title and twitter:title properties to use the WebFinger domain instead of the server hostname, which should make url previews show up a little more correctly in certain applications.
hufman added 1 commit 2023-01-23 02:30:55 +00:00
Use any custom WebFinger domain for page metadata
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
54fdf3a5de
birb commented 2023-07-27 10:40:48 +00:00
First-time contributor
Copy link

any reason why this hasn't been merged yet?
discord embeds show the hostname instead of the webfinger domain, as do embeds elsewhere

image

any reason why this hasn't been merged yet? discord embeds show the hostname instead of the webfinger domain, as do embeds elsewhere ![image](https://img.birb.cc/lxsr1cca.png)
floatingghost commented 2023-07-27 12:40:55 +00:00
Owner
Copy link

yes, the reason is that this PR has no tests in any form

it only passes because in test the config has the webfinger domain the same as the endpoint

without tests this cannot be merged

yes, the reason is that this PR has no tests in any form it only passes because in test the config has the webfinger domain the same as the endpoint without tests this cannot be merged
floatingghost commented 2023-07-27 12:41:13 +00:00
Owner
Copy link

i left it thinking the OP would add them at some point, and seems they never did

i left it thinking the OP would add them at some point, and seems they never did
hufman commented 2023-07-27 14:12:58 +00:00
Author
First-time contributor
Copy link

That would have been helpful to know, I instead had the impression that the project was dead :)
I'll try to figure out how to add tests, Erlang is new to me so it will take a while.

That would have been helpful to know, I instead had the impression that the project was dead :) I'll try to figure out how to add tests, Erlang is new to me so it will take a while.
floatingghost commented 2023-07-27 14:13:27 +00:00
Owner
Copy link

eh? dead? there's activity constantly

eh? dead? there's activity constantly
hufman added 2 commits 2023-07-27 16:02:13 +00:00
Add a unit test for custom WebFinger domain
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending
Details
ci/woodpecker/pr/docs Pipeline is pending
Details
ci/woodpecker/pr/test Pipeline is pending
Details
1377ec33fe
floatingghost reviewed 2023-07-27 16:06:50 +00:00
test/pleroma/web/web_finger/web_finger_controller_test.exs
@ -8,6 +8,7 @@ defmodule Pleroma.Web.WebFinger.WebFingerControllerTest do
import ExUnit.CaptureLog
floatingghost commented 2023-07-27 16:06:50 +00:00
Owner
Copy link

https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/test/pleroma/web/metadata/utils_test.exs may be a more suitable place for this

https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/test/pleroma/web/metadata/utils_test.exs may be a more suitable place for this
hufman commented 2023-07-29 14:38:54 +00:00
Author
First-time contributor
Copy link

I moved the unit tests as requested.

I moved the unit tests as requested.
hufman marked this conversation as resolved
hufman added 1 commit 2023-07-28 14:35:25 +00:00
Add unit tests for Utils.user_name_string
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending
Details
ci/woodpecker/pr/docs Pipeline is pending
Details
ci/woodpecker/pr/test Pipeline is pending
Details
c38f1aefb1
hufman commented 2023-07-31 15:22:50 +00:00
Author
First-time contributor
Copy link

Is there any further feedback for this change?

Is there any further feedback for this change?
floatingghost commented 2023-07-31 16:29:32 +00:00
Owner
Copy link

there's no need to bump, it's been the weekend and it's only just now the end of the work day, I'll look at it when i get a free moment

there's no need to bump, it's been the weekend and it's only just now the end of the work day, I'll look at it when i get a free moment
floatingghost requested changes 2023-08-02 10:57:08 +00:00
floatingghost left a comment
Owner
Copy link

tests do not pass

suggestions:

  • Remove the change_config calls
  • on the "it uses the Endpoint by default" test, test that it returns @localhost
  • on the "it uses any custom WebFinger domain", you only need the WebFinger, :domain config, the Endpoint config can be removed
tests do not pass suggestions: - Remove the `change_config` calls - on the "it uses the Endpoint by default" test, test that it returns `@localhost` - on the "it uses any custom WebFinger domain", you only need the WebFinger, :domain config, the Endpoint config can be removed
test/pleroma/web/metadata/utils_test.exs
@ -79,1 +79,4 @@
end
describe "user_name_string/1" do
test "it uses the Endpoint by default" do
floatingghost commented 2023-08-02 10:55:08 +00:00
Owner
Copy link

this breaks all other tests that run after this one

this breaks all other tests that run after this one
test/pleroma/web/web_finger/web_finger_controller_test.exs
@ -8,6 +8,7 @@ defmodule Pleroma.Web.WebFinger.WebFingerControllerTest do
import ExUnit.CaptureLog
import Pleroma.Factory
import Tesla.Mock
alias Pleroma.Web.Metadata.Utils
floatingghost commented 2023-08-02 10:55:23 +00:00
Owner
Copy link

this is no longer required

this is no longer required
floatingghost commented 2023-08-02 10:58:08 +00:00
Owner
Copy link

but DW i can fix that

but DW i can fix that
floatingghost commented 2023-08-02 11:05:59 +00:00
Owner
Copy link

merged via babb4b9a8f

merged via babb4b9a8fc89445e485f8c2955b8ebd0e77bc55
floatingghost closed this pull request 2023-08-02 11:05:59 +00:00
hufman commented 2023-08-02 14:15:23 +00:00
Author
First-time contributor
Copy link

Weird, MIX_ENV=test mix test test/pleroma/web/metadata/ worked fine for me.
Thanks for accepting!

Weird, `MIX_ENV=test mix test test/pleroma/web/metadata/` worked fine for me. Thanks for accepting!
floatingghost commented 2023-08-02 14:16:28 +00:00
Owner
Copy link

the reason that worked is that that command only tests that particular subset of tests - changing the endpoint config fails other tests outside of that subset because config can persist between tests (and is actually a frequent pain point)

the reason that worked is that that command only tests that particular subset of tests - changing the endpoint config fails other tests outside of that subset because config can persist between tests (and is actually a frequent pain point)
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending
Details
ci/woodpecker/pr/docs Pipeline is pending
Details
ci/woodpecker/pr/test Pipeline is pending
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
floatingghost
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#442
No description provided.
Delete branch "hufman/akkoma:metadata_webfinger"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?