AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 177 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

fix invalid proxy_hide_header in example config #472

Merged
floatingghost merged 2 commits from flisk/akkoma:remote-media-docs-fix into develop 2023-03-02 11:19:47 +00:00
Conversation 4 Commits 2 Files changed 1 +24 -11
flisk commented 2023-02-18 13:17:02 +00:00
Contributor
Copy link

proxy_hide_header takes one header per statement in any nginx version i'm aware of, so the current version is probably a typo.

somewhat related: the media proxy config on this page differs a bit from the one in installation/nginx/akkoma.nginx, and it's not really obvious to me which one i should be using. i'm still looking into this, but maybe someone has input on how i could make the docs more consistent?

`proxy_hide_header` takes one header per statement in any nginx version i'm aware of, so the current version is probably a typo. somewhat related: the media proxy config on this page differs a bit from the one in `installation/nginx/akkoma.nginx`, and it's not really obvious to me which one i should be using. i'm still looking into this, but maybe someone has input on how i could make the docs more consistent?
floatingghost commented 2023-02-26 22:03:04 +00:00
Owner
Copy link

hm curious

maybe there was an old nginx version that allowed this

the media proxy config on this page differs a bit from the one in installation/nginx/akkoma.nginx, and it's not really obvious to me which one i should be using

the one in installation should be correct, so if it could match that it'd be great

hm curious maybe there was an old nginx version that allowed this > the media proxy config on this page differs a bit from the one in installation/nginx/akkoma.nginx, and it's not really obvious to me which one i should be using the one in `installation` should be correct, so if it could match that it'd be great
flisk force-pushed remote-media-docs-fix from 107a72e04c to 3c2fa14634 2023-02-26 22:39:49 +00:00 Compare
flisk commented 2023-02-26 22:40:24 +00:00
Author
Contributor
Copy link

how's this?

how's this?
flisk force-pushed remote-media-docs-fix from a5fc20626c to 1ab0b3a0e2 2023-02-26 22:58:59 +00:00 Compare
flisk commented 2023-02-26 22:59:20 +00:00
Author
Contributor
Copy link

(little bit of thrashing to make gitea render that link correctly, sorry)

(little bit of thrashing to make gitea render that link correctly, sorry)
floatingghost commented 2023-03-02 11:19:29 +00:00
Owner
Copy link

that's good, thanks a lot!

that's good, thanks a lot!
floatingghost merged commit c8add9d1dc into develop 2023-03-02 11:19:47 +00:00
floatingghost deleted branch remote-media-docs-fix 2023-03-02 11:19:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#472
No description provided.
Delete branch "flisk/akkoma:remote-media-docs-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?