AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 177 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

[bug] unreadable emoji directory crashes akkoma #488

New issue
Open
opened 2023-02-27 18:59:49 +00:00 by flisk · 0 comments
flisk commented 2023-02-27 18:59:49 +00:00
Contributor
Copy link

Your setup

OTP

Extra details

No response

Version

3.6.0-0-g36cb19d

PostgreSQL version

15

What were you trying to do?

i was trying to import an emoji pack by placing a directory in static/emojis and forgot to make the directory readable for the user akkoma runs under

What did you expect to happen?

a sensible error message in the admin interface

What actually happened?

akkoma crashed

Logs

Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] No emoji.txt found for pack "blobhaj", assuming all .png, .gif files are emoji
Feb 27 18:56:06 lain.gay pleroma[1401192]: [error] GenServer Pleroma.Emoji terminating
Feb 27 18:56:06 lain.gay pleroma[1401192]: ** (File.Error) could not list directory "/srv/akko/static/emoji/blobhaj": permission denied
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (elixir 1.14.3) lib/file.ex:1637: File.ls!/1
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:147: Pleroma.Emoji.Loader.find_all_emoji/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:139: Pleroma.Emoji.Loader.make_shortcode_to_file_map/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:128: Pleroma.Emoji.Loader.load_pack/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (elixir 1.14.3) lib/enum.ex:4249: Enum.flat_map_list/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (elixir 1.14.3) lib/enum.ex:4250: Enum.flat_map_list/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:68: Pleroma.Emoji.Loader.load/0
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji.ex:90: Pleroma.Emoji.handle_cast/2
Feb 27 18:56:06 lain.gay pleroma[1401192]: Last message: {:"$gen_cast", :reload}
Feb 27 18:56:06 lain.gay pleroma[1401192]: State: nil
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Found emoji packs: 8bfont, blobcat, blobfox, blobfox_flip, meow, nko, blobhaj
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/8bfont/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobcat/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobfox/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobfox_flip/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/meow/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/nko/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] No emoji.txt found for pack "blobhaj", assuming all .png, .gif files are emoji
Feb 27 18:56:06 lain.gay pleroma[1401192]: [error] GenServer Pleroma.Emoji terminating
Feb 27 18:56:06 lain.gay pleroma[1401192]: ** (File.Error) could not list directory "/srv/akko/static/emoji/blobhaj": permission denied
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (elixir 1.14.3) lib/file.ex:1637: File.ls!/1
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:147: Pleroma.Emoji.Loader.find_all_emoji/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:139: Pleroma.Emoji.Loader.make_shortcode_to_file_map/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:128: Pleroma.Emoji.Loader.load_pack/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (elixir 1.14.3) lib/enum.ex:4249: Enum.flat_map_list/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (elixir 1.14.3) lib/enum.ex:4250: Enum.flat_map_list/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:68: Pleroma.Emoji.Loader.load/0
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji.ex:90: Pleroma.Emoji.handle_cast/2
Feb 27 18:56:06 lain.gay pleroma[1401192]: Last message: {:"$gen_cast", :reload}
Feb 27 18:56:06 lain.gay pleroma[1401192]: State: nil
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Found emoji packs: 8bfont, blobcat, blobfox, blobfox_flip, meow, nko, blobhaj
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/8bfont/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobcat/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobfox/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobfox_flip/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/meow/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/nko/pack.json
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] No emoji.txt found for pack "blobhaj", assuming all .png, .gif files are emoji
Feb 27 18:56:06 lain.gay pleroma[1401192]: [error] GenServer Pleroma.Emoji terminating
Feb 27 18:56:06 lain.gay pleroma[1401192]: ** (File.Error) could not list directory "/srv/akko/static/emoji/blobhaj": permission denied
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (elixir 1.14.3) lib/file.ex:1637: File.ls!/1
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:147: Pleroma.Emoji.Loader.find_all_emoji/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:139: Pleroma.Emoji.Loader.make_shortcode_to_file_map/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:128: Pleroma.Emoji.Loader.load_pack/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (elixir 1.14.3) lib/enum.ex:4249: Enum.flat_map_list/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (elixir 1.14.3) lib/enum.ex:4250: Enum.flat_map_list/2
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:68: Pleroma.Emoji.Loader.load/0
Feb 27 18:56:06 lain.gay pleroma[1401192]:     (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji.ex:90: Pleroma.Emoji.handle_cast/2
Feb 27 18:56:06 lain.gay pleroma[1401192]: Last message: {:"$gen_cast", :reload}
Feb 27 18:56:06 lain.gay pleroma[1401192]: State: nil
Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Postgrex.Protocol (#PID<0.4368.0>) disconnected: ** (DBConnection.ConnectionError) client #PID<0.4522.0> exited
Feb 27 18:56:06 lain.gay pleroma[1401192]: [notice] Application pleroma exited: shutdown

Severity

I can manage

Have you searched for this issue?

  • I have double-checked and have not found this issue mentioned anywhere.
### Your setup OTP ### Extra details _No response_ ### Version 3.6.0-0-g36cb19d ### PostgreSQL version 15 ### What were you trying to do? i was trying to import an emoji pack by placing a directory in `static/emojis` and forgot to make the directory readable for the user akkoma runs under ### What did you expect to happen? a sensible error message in the admin interface ### What actually happened? akkoma crashed ### Logs ```shell Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] No emoji.txt found for pack "blobhaj", assuming all .png, .gif files are emoji Feb 27 18:56:06 lain.gay pleroma[1401192]: [error] GenServer Pleroma.Emoji terminating Feb 27 18:56:06 lain.gay pleroma[1401192]: ** (File.Error) could not list directory "/srv/akko/static/emoji/blobhaj": permission denied Feb 27 18:56:06 lain.gay pleroma[1401192]: (elixir 1.14.3) lib/file.ex:1637: File.ls!/1 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:147: Pleroma.Emoji.Loader.find_all_emoji/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:139: Pleroma.Emoji.Loader.make_shortcode_to_file_map/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:128: Pleroma.Emoji.Loader.load_pack/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (elixir 1.14.3) lib/enum.ex:4249: Enum.flat_map_list/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (elixir 1.14.3) lib/enum.ex:4250: Enum.flat_map_list/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:68: Pleroma.Emoji.Loader.load/0 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji.ex:90: Pleroma.Emoji.handle_cast/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: Last message: {:"$gen_cast", :reload} Feb 27 18:56:06 lain.gay pleroma[1401192]: State: nil Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Found emoji packs: 8bfont, blobcat, blobfox, blobfox_flip, meow, nko, blobhaj Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/8bfont/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobcat/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobfox/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobfox_flip/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/meow/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/nko/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] No emoji.txt found for pack "blobhaj", assuming all .png, .gif files are emoji Feb 27 18:56:06 lain.gay pleroma[1401192]: [error] GenServer Pleroma.Emoji terminating Feb 27 18:56:06 lain.gay pleroma[1401192]: ** (File.Error) could not list directory "/srv/akko/static/emoji/blobhaj": permission denied Feb 27 18:56:06 lain.gay pleroma[1401192]: (elixir 1.14.3) lib/file.ex:1637: File.ls!/1 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:147: Pleroma.Emoji.Loader.find_all_emoji/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:139: Pleroma.Emoji.Loader.make_shortcode_to_file_map/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:128: Pleroma.Emoji.Loader.load_pack/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (elixir 1.14.3) lib/enum.ex:4249: Enum.flat_map_list/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (elixir 1.14.3) lib/enum.ex:4250: Enum.flat_map_list/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:68: Pleroma.Emoji.Loader.load/0 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji.ex:90: Pleroma.Emoji.handle_cast/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: Last message: {:"$gen_cast", :reload} Feb 27 18:56:06 lain.gay pleroma[1401192]: State: nil Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Found emoji packs: 8bfont, blobcat, blobfox, blobfox_flip, meow, nko, blobhaj Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/8bfont/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobcat/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobfox/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/blobfox_flip/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/meow/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Loading emoji pack from JSON: /srv/akko/static/emoji/nko/pack.json Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] No emoji.txt found for pack "blobhaj", assuming all .png, .gif files are emoji Feb 27 18:56:06 lain.gay pleroma[1401192]: [error] GenServer Pleroma.Emoji terminating Feb 27 18:56:06 lain.gay pleroma[1401192]: ** (File.Error) could not list directory "/srv/akko/static/emoji/blobhaj": permission denied Feb 27 18:56:06 lain.gay pleroma[1401192]: (elixir 1.14.3) lib/file.ex:1637: File.ls!/1 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:147: Pleroma.Emoji.Loader.find_all_emoji/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:139: Pleroma.Emoji.Loader.make_shortcode_to_file_map/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:128: Pleroma.Emoji.Loader.load_pack/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (elixir 1.14.3) lib/enum.ex:4249: Enum.flat_map_list/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (elixir 1.14.3) lib/enum.ex:4250: Enum.flat_map_list/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji/loader.ex:68: Pleroma.Emoji.Loader.load/0 Feb 27 18:56:06 lain.gay pleroma[1401192]: (pleroma 3.6.0-0-g36cb19d) lib/pleroma/emoji.ex:90: Pleroma.Emoji.handle_cast/2 Feb 27 18:56:06 lain.gay pleroma[1401192]: Last message: {:"$gen_cast", :reload} Feb 27 18:56:06 lain.gay pleroma[1401192]: State: nil Feb 27 18:56:06 lain.gay pleroma[1401192]: [info] Postgrex.Protocol (#PID<0.4368.0>) disconnected: ** (DBConnection.ConnectionError) client #PID<0.4522.0> exited Feb 27 18:56:06 lain.gay pleroma[1401192]: [notice] Application pleroma exited: shutdown ``` ### Severity I can manage ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.
flisk added the
bug
 label 2023-02-27 18:59:49 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
develop
translations
customizable-docker-db
stable
static-adminfe
bad-uploader-config-warning
docker
user-expiry-backfill
config-db-keys
ensure-scrubbers-loaded
otp26
code-shaking-does-not-go-brr
elixir1.15
circleci
backup-fixes
mod-task
policy
mrf-coolness
frontend-switcher-9000
contentMap
language-on-posts
rabbit
credo-on-pr
unify-http
normalise-markup-by-default
buildx
v3.13.2
v2.6.3
v3.13.1
v3.13.0
snac-3.12.1.2
v3.12.2
snac-3.12.1.1
v3.12.1
v3.12.0
v3.11.0
v2.6.2
v2.6.1
2.6.1
v2.6.0
v2.5.5
v3.10.4
v3.10.3
v3.10.2
v3.10.1
v3.10.0
v2.5.4
v2.5.3
v3.9.3
v3.9.2
v3.9.1
V3.9.0
2023.05
v3.8.0
v3.7.1
v3.7.0
v3.6.0
v3.5.0
v2.4.5
v3.4.0
v3.3.1
v2.4.4
v3.3.0
v3.2.3
v3.2.2
v3.2.1
stable-202209
v3.2.0
v3.1.0
stable-2022.07
v3.0.0
v0.0.1
v2.5.2-6
v2.5.2-5
v2.5.2-4
v2.5.2-3
v2.5.2-2
v2.5.2-1
v2.5.2
v2.5.1
v2.5.0-8
v2.5.0-7
v2.5.0-6
v2.5.0-5
v2.5.0-4
v2.5.0-3
v2.5.0-2
v2.5.0-1
v2.5.0
v2.4.3
pre-rebase
v2.4.2
v2.4.1
v2.4.0
soapbox-v1.1.1
soapbox-v1.1.0
soapbox-v1.0.0
v2.3.0
v2.2.2
v2.2.1
v2.2.0
v2.1.2
v2.1.1
v2.1.0
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0
v1.1.9
v1.1.8
v1.1.7
v1.1.6
v1.1.5
v1.1.4
v1.1.3
v1.1.2
v1.1.1
v1.1.0
v1.0.91
v1.0.90
v1.0.7
v1.0.6
v1.0.5
v1.0.4
v1.0.3
v1.0.2
v1.0.1
v1.0.0
v0.9.0
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#488
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?