Make UserNote comment default to the empty string. #530

Merged

floatingghost merged 3 commits from provable_ascent/akkoma:provable_ascent-patch-1 into develop

2023-05-22 21:33:02 +00:00

provable_ascent commented

2023-04-27 05:22:56 +00:00

Contributor

This makes the behavior consistent between when UserNote doesn't exist and when comment is null.

The current behavior may return null in APIs, which misleads some clients doing feature detection into thinking the server does not support comments.
For example, see https://codeberg.org/husky/husky/issues/92

This makes the behavior consistent between when UserNote doesn't exist and when comment is null. The current behavior may return null in APIs, which misleads some clients doing feature detection into thinking the server does not support comments. For example, see https://codeberg.org/husky/husky/issues/92

provable_ascent added 1 commit 2023-04-27 05:22:57 +00:00

ci/woodpecker/pr/woodpecker Pipeline is pending Details

d8bed0ff63 Make UserNote comment default to the empty string.

This make the behavior consistent between when UserNote doesn't exist and when comment is null.

The current behavior may return null in APIs, which misleads some clients doing feature detection into thinking the server does not support comments.
For example, see https://codeberg.org/husky/husky/issues/92