[bug] Cannot approve User using admin-fe #560
Labels
No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: AkkomaGang/akkoma#560
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Your setup
From source
Extra details
Ubuntu 22.04.2 LTS
Version
3.9.3-28-g9d7c877d (stable)
PostgreSQL version
14
What were you trying to do?
I am not 100% sure if this is an issue with admin-fe or with the backend, but it looks to be a backend-thing, so I decided to post on this repo.
The issue started a few weeks ago and backend-updates as well as reinstalling admin-fe did not help. If I remember correctly approval used to work correctly. Then I changed some settings in admin-fe namely I populated "Welome messages" under Settings -> Instance -> Welcome -> Direct Messages/E-Mail and then approval stopped working. I don't know in which way this related but I thought I might mention it anyway just to give a full picture. Here is the actual Problem discription:
I registered a new User. Email for confirming E-Mail Adress went fine. Confirming E-Mail worked. Using admin-FE I tried to approve a User and it failed. The User was not approved and the account cannot log in.
What did you expect to happen?
The User gets approved properly and can login normally.
What actually happened?
The approval fails and the newly registered User cannot login. Error states the account needs to be approved prior to logging in.
Logs
Severity
I cannot use it as easily as I'd like
Have you searched for this issue?
Been getting the same problem but my logs look a bit different
Can confirm it works after disabling the welcome message stuff and restarting akkoma.
EDIT2: am baka, skip this and read next message
original message (investigating the wrong thing)
i’ve tried various register inputs to get the DB to contain an empty string as an email but without success. Sending `"email":""` or `"email":" "` etc in the registration API call, all lead to an explicit `NULL` in the DB and the welcome email seems to just be skipped.Manually modifying the DB to contain an empty string as email for an unapproved user, leads to the same error as norm got though.
I guess the root bug here is somehow registrations leading to an empty string rather than
NULL
. But since such pending users already exist we prob should skip emails on empty strings tooThis patch seems to suffice for the latter, but i’ll wait and see if we can get more insight into how it even came this far first:
EDIT: or maybe not quite sufficeint (depending on adapter?), checking logs again it might have tried to send an email without any
to
fielddisregard everything i wrote before, i just didn’t notice the empty address was the sender rather than receiver
Should be easily fixed by properly specifying the address in the config
The original issue reported by stefan230 occurs in a completely different place and is probably something else. Unfortunately the backtrace doesn't even (go back far enough to) contain any akkoma source code, making it hard to guess what/where things went wrong