Use OS CA store for Mint HTTP connections #573

Merged

floatingghost merged 1 commit from XxXCertifiedForkliftDriverXxX/akkoma:fix/use-os-certs into develop

2023-06-28 00:52:27 +00:00

XxXCertifiedForkliftDriverXxX commented

2023-06-23 18:40:36 +00:00

Contributor

Yo, listen up, I got a pull request to drop,
Bringing some changes that'll make your jaw drop,
Proposing to use the OS's certificate authority store,
It's a move that'll make our security score soar.

With this update, admins gain the power
To untrust CAs like Cloudflare, make them cower,
Trust yourself and your friends, like localhost CAs for dev,
Flexibility and control, that's what you're gonna have.

Integration with the OS, that's the key,
Akkoma's gonna rock it, you'll see,
Expect more seamless behavior, no doubt,
For developers and admins, this is what it's about.

So let's merge this PR, make it official,
Certified forklift driver, I'm here to deliver,
Better security, better integration, that's the deal,
Let's take Akkoma to the next level, for real!

Yo, listen up, I got a pull request to drop, Bringing some changes that'll make your jaw drop, Proposing to use the OS's certificate authority store, It's a move that'll make our security score soar. With this update, admins gain the power To untrust CAs like Cloudflare, make them cower, Trust yourself and your friends, like localhost CAs for dev, Flexibility and control, that's what you're gonna have. Integration with the OS, that's the key, Akkoma's gonna rock it, you'll see, Expect more seamless behavior, no doubt, For developers and admins, this is what it's about. So let's merge this PR, make it official, Certified forklift driver, I'm here to deliver, Better security, better integration, that's the deal, Let's take Akkoma to the next level, for real!

floatingghost commented

2023-06-26 12:34:26 +00:00

Owner

dank u forklift-san very cool

since most of the added functions are dupes of AdapterHelper functions, you could probably reduce the duplication and shove the CA loading in that module instead? feels a bit weird to have multiple definitions of essentially the same thing

like maybe_add_proxy_pool should already be adding pools and conn opts, so you can probably piggyback off of those funcs

dank u forklift-san very cool since most of the added functions are dupes of AdapterHelper functions, you could probably reduce the duplication and shove the CA loading in that module instead? feels a bit weird to have multiple definitions of essentially the same thing like `maybe_add_proxy_pool` should already be adding pools and conn opts, so you can probably piggyback off of those funcs

XxXCertifiedForkliftDriverXxX force-pushed fix/use-os-certs from bfe177bc95 to 767e1272b3

2023-06-26 13:51:23 +00:00

Compare

XxXCertifiedForkliftDriverXxX commented

2023-06-26 13:51:29 +00:00

Author

Contributor

Yo, sorry 'bout the mess, my friend,
I was debuggin' way back when,
Forgot to clean it up, my bad,
But now it's fixed, ain't that rad?

Used this patch for some debugging,
But now it's time for some spring cleaning,
Polished it up, made it shine,
Now it's good to go, no more decline.

I'll make sure it's tidy, no more mess,
Certified forklift driver, I impress,
With precision and care, I'll pave the way,
For a smooth ride, day after day.

Certified forklift driver, on the go,
Got the skills to lift, you know,
Patch is lookin' good, all clean,
Ready to roll, like a well-oiled machine!

So here it is, all spick and span,
No more worries, it's part of the plan,
Certified forklift driver, I deliver,
A flawless patch, now let's all sliver!

Yo, sorry 'bout the mess, my friend, I was debuggin' way back when, Forgot to clean it up, my bad, But now it's fixed, ain't that rad? Used this patch for some debugging, But now it's time for some spring cleaning, Polished it up, made it shine, Now it's good to go, no more decline. I'll make sure it's tidy, no more mess, Certified forklift driver, I impress, With precision and care, I'll pave the way, For a smooth ride, day after day. Certified forklift driver, on the go, Got the skills to lift, you know, Patch is lookin' good, all clean, Ready to roll, like a well-oiled machine! So here it is, all spick and span, No more worries, it's part of the plan, Certified forklift driver, I deliver, A flawless patch, now let's all sliver!

floatingghost commented

2023-06-28 00:52:21 +00:00

Owner

seems good now thanks lil' forklift