[bug] Emoji react does not disappear, shows 0 instead #584

New issue

Closed

opened 2023-07-09 16:20:48 +00:00 by Ghost · 3 comments

Ghost commented

2023-07-09 16:20:48 +00:00

Your setup

Docker

Extra details

Arch linux building docker image from source

Version

8c956bc671

PostgreSQL version

14.8

What were you trying to do?

I deactivated a user for spamming and noticed their emoji reactions were still visible on posts, despite there being "0" users who have reacted.

What did you expect to happen?

Emoji reaction should not show up if there are 0 accounts listed.

What actually happened?

Emoji react is still visible even when no accounts have used it, after deactivating the person who put it on.

Logs

No response

Severity

I can manage

Have you searched for this issue?

I have double-checked and have not found this issue mentioned anywhere.

### Your setup Docker ### Extra details Arch linux building docker image from source ### Version 8c956bc671 ### PostgreSQL version 14.8 ### What were you trying to do? I deactivated a user for spamming and noticed their emoji reactions were still visible on posts, despite there being "0" users who have reacted. ### What did you expect to happen? Emoji reaction should not show up if there are 0 accounts listed. ### What actually happened? Emoji react is still visible even when no accounts have used it, after deactivating the person who put it on. ### Logs _No response_ ### Severity I can manage ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.

Screenshot 2023-07-09 191557.png

5.5 KiB

Ghost added the

bug

label 2023-07-09 16:20:48 +00:00

ashtentheplatypus commented

2023-07-13 23:37:57 +00:00

I've also noticed that from a refreshed page, it'll show the original number of users who reacted, and then only drop it down to zero on mouse-hover.

Even if it's a patch-work temporary solution, I'd love to know if there's a way to remove the affected emojis while waiting for the bug to get fixed.

I'm also having this issue. I underestimated the importance of blocking certain remote instances, and ended up having my instance get brigaded. The comments cleaned up fine, but the puke and laugh emoji reacts are plastered all over the place, unfortunately. I've also noticed that from a refreshed page, it'll show the original number of users who reacted, and then only drop it down to zero on mouse-hover. Even if it's a patch-work temporary solution, I'd love to know if there's a way to remove the affected emojis while waiting for the bug to get fixed.

floatingghost commented

2023-07-14 01:08:12 +00:00

Owner

however adding cleanup to the objectv pruner scheduled task to take care of this is certainly doable I think

so the reason this happens is that reactions are actually stored inline on the activity itself (don't ask, long story), so deactivating a user won't scrub reaction data, and it would be rather intensive to do it on demand however adding cleanup to the objectv pruner scheduled task to take care of this is certainly doable I think

❤️ 1

floatingghost commented

2023-07-17 18:49:19 +00:00

Owner

fixed via 8fe29bf5d2

fixed via 8fe29bf5d2f6899f646c2b767

❤️ 1