AkkomaGang/akkoma

Fork 94

[bug] repeats are shown broken with restrict_unauthenticated, should be hidden entirely #597

New issue

Open

opened 2023-07-20 21:07:04 +00:00 by YokaiRick · 1 comment

YokaiRick commented

2023-07-20 21:07:04 +00:00

Contributor

Your setup

From source

Extra details

Ubuntu 22.04

Version

33e7ae7637

PostgreSQL version

No response

What were you trying to do?

I want use these restrict_unauthenticated settings:

config :pleroma, :restrict_unauthenticated,
  timelines: %{local: false, federated: true},
  profiles: %{local: false, remote: true},
  activities: %{local: false, remote: true}

This way any not logged in user can see (as intended) my profile and my posts.
But they can also see my repeats, and in a kinda broken way, like in this attached screenshot.

Link to the post: https://a.n0id.space/notice/AXtSzz0PR0EkE2VZtw
Also see attached screenshot

I moved the issue from FE repo to here, cause it seems to be more a backend issue

Originally posted by @YokaiRick in /AkkomaGang/akkoma-fe/issues/302#issue-1359

What did you expect to happen?

I think they should be hidden completely, cause this kinda dissents the activities: %{local: false, remote: true} setting

What actually happened?

Ppl can see remote posts, in a broken way.

Logs

No response

Severity

I can manage

Have you searched for this issue?

I have double-checked and have not found this issue mentioned anywhere.

### Your setup From source ### Extra details Ubuntu 22.04 ### Version 33e7ae7637236b859bfabc9016a86e4bbe1e0632 ### PostgreSQL version _No response_ ### What were you trying to do? I want use these restrict_unauthenticated settings: ``` config :pleroma, :restrict_unauthenticated, timelines: %{local: false, federated: true}, profiles: %{local: false, remote: true}, activities: %{local: false, remote: true} ``` This way any not logged in user can see (as intended) my profile and my posts. But they can also see my repeats, and in a kinda broken way, like in this attached screenshot. Link to the post: https://a.n0id.space/notice/AXtSzz0PR0EkE2VZtw Also see attached screenshot I moved the issue from FE repo to here, cause it seems to be more a backend issue _Originally posted by @YokaiRick in /AkkomaGang/akkoma-fe/issues/302#issue-1359_ ### What did you expect to happen? I think they should be hidden completely, cause this kinda dissents the `activities: %{local: false, remote: true}` setting ### What actually happened? Ppl can see remote posts, in a broken way. ### Logs _No response_ ### Severity I can manage ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.

1689887176-grim.png

378 KiB

YokaiRick added the

bug

label 2023-07-20 21:07:04 +00:00

YokaiRick changed title from ~~[bug]~~ to [bug] repeats are shown broken with restrict_unauthenticated, should be hidden entirely

2023-07-20 21:07:25 +00:00

YokaiRick commented

2023-07-20 21:08:17 +00:00

Author

Contributor

fun fact, i just discovered the post only loads if i click on the '2h ago' thread link in the same tab. if i open it any other tab it doesn't load as intended 🤔

aka you can reproduce this this way:

set :restrict_unauthenticated settings as above
repeat a remote post
open a private tab, go to your profile, there you see the broken post repeated
if you click on the thread url the broken post opens in the same tab.
if you copy the thread url and open another private tab, past the link, the post doesn't get shown as intended.

hopefully my description isn't too confusing

fun fact, i just discovered the post only loads if i click on the '2h ago' thread link in the same tab. if i open it any other tab it doesn't load as intended 🤔 aka you can reproduce this this way: 1. set :restrict_unauthenticated settings as above 2. repeat a remote post 3. open a private tab, go to your profile, there you see the broken post repeated 4. if you click on the thread url the broken post opens in the same tab. 5. if you copy the thread url and open another private tab, past the link, the post doesn't get shown as intended. hopefully my description isn't too confusing

YokaiRick referenced this issue from AkkomaGang/akkoma-fe

2023-07-20 21:08:43 +00:00

[bug] repeats are shown broken with restrict_unauthenticated, should be hidden entirely #302

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#597

No description provided.