AkkomaGang/akkoma
AkkomaGang
/
akkoma
12
63
Fork 83
Code Issues 167 Pull Requests 14 Packages Projects 2 Releases 13 Wiki Activity

Completely disable xml entity resolution #614

Merged
floatingghost merged 1 commits from MaeIsBad/akkoma:completely-disable-xml-entity-resolution into develop 2023-08-05 12:36:29 +00:00
Conversation 2 Commits 1 Files Changed 4 +22 -2
MaeIsBad commented 2023-08-05 12:31:56 +00:00
Contributor
Copy Link

I misunderstood how the fetch_fun option on xmerl_scan.string worked. While the previous patch was sufficient to prevent reading local files it still could be DOSed with a billion laughs attack.

I misunderstood how the fetch_fun option on xmerl_scan.string worked. While the previous patch was sufficient to prevent reading local files it still could be DOSed with a billion laughs attack.
MaeIsBad force-pushed completely-disable-xml-entity-resolution from 1c9ca126d9 to d868348fac 2023-08-05 12:32:08 +00:00 Compare
floatingghost commented 2023-08-05 12:32:48 +00:00
Owner
Copy Link

wowee cutting it CLOOOOSE on this one, i was literally just putting the release out - thanks a lot!

wowee cutting it CLOOOOSE on this one, i was literally just putting the release out - thanks a lot!
❤️ 1
floatingghost commented 2023-08-05 12:36:25 +00:00
Owner
Copy Link

all tests pass, good by me!

all tests pass, good by me!
floatingghost merged commit 643e7dd7c1 into develop 2023-08-05 12:36:29 +00:00
floatingghost deleted branch completely-disable-xml-entity-resolution 2023-08-05 12:36:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#614
No description provided.
Delete Branch "MaeIsBad/akkoma:completely-disable-xml-entity-resolution"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?