AkkomaGang/akkoma

Fork 93

[bug] MRF transparency showing policies not actually enabled #622

New issue

Closed

opened 2023-08-08 23:05:30 +00:00 by norm · 1 comment

norm commented

2023-08-08 23:05:30 +00:00

Contributor

Your setup

From source

Extra details

Fedora 38

Version

2023.08

PostgreSQL version

What were you trying to do?

I currently have the following MRF policies enabled via AdminFE:

ObjectAgePolicy
TagPolicy
SimplePolicy
NormalizeMarkup

Despite this, the MRF transparency also shows the the following policies (from the about page):

HashtagPolicy
InlineQuotePolicy
DirectMessageDisabledPolicy

I can confirm the DirectMessageDisabledPolicy is not active for instance since we still get DMs from remote instances just fine.

What did you expect to happen?

The MRF transparency only shows the policies enabled on the instance.

What actually happened?

MRF transparency shows policies that aren't actually enabled as stated above.

Logs

No response

Severity

I can manage

Have you searched for this issue?

I have double-checked and have not found this issue mentioned anywhere.

### Your setup From source ### Extra details Fedora 38 ### Version 2023.08 ### PostgreSQL version 15 ### What were you trying to do? I currently have the following MRF policies enabled via AdminFE: - ObjectAgePolicy - TagPolicy - SimplePolicy - NormalizeMarkup ![image](/attachments/ca7c1e56-9869-4676-a12f-fedbae8de6ce) Despite this, the MRF transparency also shows the the following policies (from the about page): - HashtagPolicy - InlineQuotePolicy - DirectMessageDisabledPolicy ![image](/attachments/004471a2-7bd1-4c10-ad3b-4a8bc9dbedc1) I can confirm the DirectMessageDisabledPolicy is not active for instance since we still get DMs from remote instances just fine. ### What did you expect to happen? The MRF transparency only shows the policies enabled on the instance. ### What actually happened? MRF transparency shows policies that aren't actually enabled as stated above. ### Logs _No response_ ### Severity I can manage ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.

image.png

110 KiB

image.png

7.4 KiB

norm added the

bug

label 2023-08-08 23:05:30 +00:00

floatingghost commented

2023-08-12 12:58:19 +00:00

Owner

ah now this is actually incorrect, those policies are enabled, they're built in and configurationless and they're how some functionality is implemented

see: https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/web/activity_pub/mrf.ex#L146

InlineQuotePolicy is the thing that adds the fallback "RE: link" to posts

NormalizeMarkup is a security one and ensures all content goes through scrubbers

DirectMessageDisabledPolicy checks if a user has disabled or limited direct messages before accepting

as for hashtag policy i'm genuinely not sure why it's perma-enabled, it was there from pleroma - i'll look into that one

but as for the issue itself, this is not an issue and is 100% intentional

ah now this is actually incorrect, those policies _are_ enabled, they're built in and configurationless and they're how some functionality is implemented see: https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/web/activity_pub/mrf.ex#L146 InlineQuotePolicy is the thing that adds the fallback "RE: link" to posts NormalizeMarkup is a security one and ensures all content goes through scrubbers DirectMessageDisabledPolicy checks if a user has disabled or limited direct messages before accepting as for hashtag policy i'm genuinely not sure why it's perma-enabled, it was there from pleroma - i'll look into that one but as for the issue itself, this is not an issue and is 100% intentional

👍 1

floatingghost closed this issue

2023-08-12 12:58:19 +00:00

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#622

No description provided.