AkkomaGang/akkoma
AkkomaGang
/
akkoma
12
63
Fork 83
Code Issues 166 Pull Requests 14 Packages Projects 2 Releases 13 Wiki Activity

mastodon_api: Add /api/v1/preferences endpoint #625

Merged
floatingghost merged 1 commits from redstrate/akkoma:work/redstrate/preferences into develop 2023-08-12 13:59:04 +00:00
Conversation 4 Commits 1 Files Changed 5 +61 -1
redstrate commented 2023-08-12 13:19:36 +00:00
Contributor
Copy Link

I work on Tokodon, a fediverse client that uses the Mastodon API. I noticed that Akkoma doesn't implement the preferences API, which results in a not-so-pretty error 😄

Unfortunately, I see that not a lot of (Mastodon's) preferences are exposed in the default frontend - and the ones that are the only real one that's stored server-side is the default post visibility. This change implements this to the best of what we have, and will at least quell clients that ask for it. If anyone has any ideas of how else we can fill the data (maybe read out of the mastodon fe preferences map?) I'd appreciate ideas.

Tests for the one piece of working functionality is added as well.

I work on Tokodon, a fediverse client that uses the Mastodon API. I noticed that Akkoma doesn't implement the preferences API, which results in a not-so-pretty error 😄 Unfortunately, I see that not a lot of (Mastodon's) preferences are exposed in the default frontend - and the ones that are the only real one that's stored server-side is the default post visibility. This change implements this to the best of what we have, and will at least quell clients that ask for it. If anyone has any ideas of how else we can fill the data (maybe read out of the mastodon fe preferences map?) I'd appreciate ideas. Tests for the one piece of working functionality is added as well.
floatingghost commented 2023-08-12 13:26:19 +00:00
Owner
Copy Link

oh wowee you got this up fast, thanks! far better than us just saying "yea not supported" i guess

the code looks ok, but CI is screaming about formatting - any chance you could run "mix format" and commit those changes? i'll set the tests off to run then :dance:

oh wowee you got this up fast, thanks! far better than us just saying "yea not supported" i guess the code looks ok, but CI is screaming about formatting - any chance you could run "mix format" and commit those changes? i'll set the tests off to run then :dance:
redstrate commented 2023-08-12 13:27:00 +00:00
Author
Contributor
Copy Link

oh wowee you got this up fast, thanks! far better than us just saying "yea not supported" i guess

the code looks ok, but CI is screaming about formatting - any chance you could run "mix format" and commit those changes? i'll set the tests off to run then :dance:

Yes I can, I was about to ask if there was some kind of auto-formatter

> oh wowee you got this up fast, thanks! far better than us just saying "yea not supported" i guess > > the code looks ok, but CI is screaming about formatting - any chance you could run "mix format" and commit those changes? i'll set the tests off to run then :dance: Yes I can, I was about to ask if there was some kind of auto-formatter
redstrate force-pushed work/redstrate/preferences from 3602022484 to c22ecac567 2023-08-12 13:28:35 +00:00 Compare
redstrate commented 2023-08-12 13:29:12 +00:00
Author
Contributor
Copy Link

Done, should be formatted correctly now 🎉

Done, should be formatted correctly now 🎉
floatingghost commented 2023-08-12 13:58:53 +00:00
Owner
Copy Link

this seems ok - some very minor compiler warnings that i'll fix up for you (like literally "bls put this function next to others of the same name" style), but everything passes

all good here, thanks a lot!

this seems ok - some very minor compiler warnings that i'll fix up for you (like literally "bls put this function next to others of the same name" style), but everything passes all good here, thanks a lot!
floatingghost merged commit 2df7707060 into develop 2023-08-12 13:59:04 +00:00
floatingghost deleted branch work/redstrate/preferences 2023-08-12 13:59:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#625
No description provided.
Delete Branch "redstrate/akkoma:work/redstrate/preferences"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?