Fix SimplePolicy blocking account updates #692

Merged

floatingghost merged 1 commits from Oneric/akkoma:fix-background_removal into develop

2024-02-17 10:34:16 +00:00

Oneric commented

2024-02-17 02:15:00 +00:00

Member

Sorry for the trouble, turns out there’s an issue with the just merged background_removal MRF addition. On the bright side the fix is very simple.

This fixes an oversight in e99e2407f3 which added background_removal as a possible SimplePolicy setting.
However, it did not add a default value to the base config and as it turns out instance_list doesn’t handle unset options well.

In effect this caused federating instances with SimplePolicy enabled but background_removal not explicitly configured to always trip up for outgoing account updates in check_background_removal (and incoming updates from Sharkey).
For added ""fun"" this error was able to block account updates made e.g. via /api/v1/accounts/update_credentials.

Tests were unaffected since they explicitly override all relevant config options.

Set a default to avoid all this
(note to self: don’t forget next time, baka!)

Sorry for the trouble, turns out there’s an issue with the just merged background_removal MRF addition. On the bright side the fix is very simple. This fixes an oversight in e99e2407f3731eba2937b7a2db7b2ef462c99e3b which added background_removal as a possible SimplePolicy setting. However, it did _not_ add a default value to the base config and as it turns out instance_list doesn’t handle unset options well. In effect this caused federating instances with SimplePolicy enabled but background_removal not explicitly configured to always trip up for outgoing account updates in check_background_removal (and incoming updates from Sharkey). For added ""fun"" this error was able to block account updates made e.g. via /api/v1/accounts/update_credentials. Tests were unaffected since they explicitly override all relevant config options. Set a default to avoid all this (note to self: don’t forget next time, baka!)

👍 1

Oneric added 1 commit 2024-02-17 02:15:01 +00:00

ci/woodpecker/pr/build-amd64 Pipeline is pending Details

ci/woodpecker/pr/build-arm64 Pipeline is pending Details

ci/woodpecker/pr/docs Pipeline is pending Details

ci/woodpecker/pr/lint Pipeline is pending Details

ci/woodpecker/pr/test Pipeline is pending Details

3b0714c4fd Fix SimplePolicy blocking account updates

This fixes an oversight in e99e2407f3
which added background_removal as a possible SimplePolicy setting.
However, it did _not_ add a default value to the base config and
as it turns out instance_list doesn’t handle unset options well.

In effect this caused federating instances with SimplePolicy enabled
but background_removal not explicitly configured to always trip up for
outgoing account updates in check_background_removal (and incoming
updates from Sharkey).
For added ""fun"" this error was able to block account updates made
e.g. via /api/v1/accounts/update_credentials.

Tests were unaffected since they explicitly override
all relevant config options.

Set a default to avoid all this
(note to self: don’t forget next time, baka!)