AkkomaGang/akkoma
AkkomaGang
/
akkoma
12
63
Fork 83
Code Issues 167 Pull Requests 14 Packages Projects 2 Releases 13 Wiki Activity

Use mediaproxy for emoji notifications if enabled #7

Merged
floatingghost merged 1 commits from :patch/emoji-notification-mediaproxy into develop 2022-06-17 13:19:57 +00:00
Conversation 1 Commits 1 Files Changed 2 +46 -1
Ghost commented 2022-06-17 12:34:50 +00:00
First-time contributor
Copy Link

This is a follow-up to 0f5bea2465, which added an emoji_url for frontend emoji notification rendering, but unconditionally used the raw URL for it instead of passing it through the proxy-if-enabled helper.

The test is probably not strictly necessary, but might make sense to keep it from breaking again later.

This is a follow-up to 0f5bea2465006bf6a0871812c056ec737ad61949, which added an `emoji_url` for frontend emoji notification rendering, but unconditionally used the raw URL for it instead of passing it through the proxy-if-enabled helper. The test is probably not strictly necessary, but might make sense to keep it from breaking again later.
Ghost added 1 commit 2022-06-17 12:34:50 +00:00
ci/woodpecker/pr/lint Pipeline was successful Details
ci/woodpecker/pr/release Pipeline was successful Details
ci/woodpecker/pr/test Pipeline was successful Details
f2f8b81fc4
Use mediaproxy for emoji notifications if enabled
floatingghost commented 2022-06-17 13:19:53 +00:00
Owner
Copy Link

ah, good spot

ah, good spot
floatingghost merged commit 8e3115e87b into develop 2022-06-17 13:19:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#7
No description provided.
Delete Branch ":patch/emoji-notification-mediaproxy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?