static-fe: don’t squeeze non-square images #705

Merged

floatingghost merged 2 commits from Oneric/akkoma:staticfe-nonsquare-img into develop

2024-04-11 18:43:04 +00:00

Oneric commented

2024-02-24 04:06:48 +00:00

Member

Mainly applies to emoji and user avatars.
So far I only encountered non-square avatars from *key accounts, so matching them makes sense to me even apart from not having to worry about ensuring consistent layout with varying width. I think static-fe will only show remote user avatars in threads and redirect for remote profiles, but still. In any case, this is at least clearly better than before

Comparison image below for emoji and avatars on profile page and next to a thread:

Mainly applies to emoji and user avatars. So far I only encountered non-square avatars from *key accounts, so matching them makes sense to me even apart from not having to worry about ensuring consistent layout with varying width. I think static-fe will only show remote user avatars in threads and redirect for remote profiles, but still. In any case, this is at least clearly better than before Comparison image below for emoji and avatars on profile page and next to a thread: ![example.webp](/attachments/fcbc61f5-4ca8-4b05-83fc-3c7c9dc69483)

example.webp

174 KiB

Oneric added 2 commits 2024-02-24 04:06:49 +00:00

static-fe: don’t squeeze non-square emoji a0daec6ea1

Emoji and the navbar items want to let blend in with lines of text,
so fix their height and let the width adjust as needed.

static-fe: don’t squeeze non-square avatars

ci/woodpecker/pr/build-amd64 Pipeline is pending

Details

ci/woodpecker/pr/build-arm64 Pipeline is pending

Details

ci/woodpecker/pr/docs Pipeline is pending

Details

ci/woodpecker/pr/lint Pipeline is pending

Details

ci/woodpecker/pr/test Pipeline is pending

Details

d7c8e9df27

This will crop them to a square matching behaviour of Husky and *key
and allowing us to never worry about consistent alignment.
Note, akkoma-fe instead displays the full image with inserted spacing.