AP fetches are initiated with non-compliant Accept header #730
Labels
No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: AkkomaGang/akkoma#730
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Your setup
From source
Extra details
Alpine 3.19
Version
2d439034ca
PostgreSQL version
16
What’s wrong?
Section 3.2 of the ActivityPub spec reads
But currently, we perform fetches with
application/activity+json
instead[{"accept", "application/activity+json"}]
The same section also tells us
The SHOULD part is why we have (currently) little trouble with this in practice, but still we shouldn’t break spec here for no reason.
Just changing the one linked line is likely enough for the server, but some tests only mock HTTP responses for
application/activity+json
requests and will need updating tooI guess, ideally we also update the returned
Content-Type
header when serving an AP object (though afaict there isn’t any spec requirement about this, albeit ActivityStream spec seems to actually preferapplication/activity+json
)Severity
I can manage
Have you searched for this issue?
AP fetches are initiaed with noncompliant Accept headerto AP fetches are initiaed with non-compliant Accept headerAP fetches are initiaed with non-compliant Accept headerto AP fetches are initiated with non-compliant Accept header