Accept all standard actor types #751

Oneric · 2024-04-21T00:19:25Z

Oneric commented

2024-04-21 00:19:25 +00:00

Sorry i missed this type, now the validator covers all standard ones listed in https://www.w3.org/TR/activitystreams-vocabulary/#actor-types and we now have real-world test samples for each one

Fixes https://meta.akkoma.dev/t/unable-to-follow-bots/705

Sorry i missed this type, now the validator covers all standard ones listed in https://www.w3.org/TR/activitystreams-vocabulary/#actor-types and we now have real-world test samples for each one Fixes https://meta.akkoma.dev/t/unable-to-follow-bots/705

floatingghost reviewed 2024-04-23 15:28:50 +00:00

lib/pleroma/web/activity_pub/object_validators/user_validator.ex Outdated

					
				@ -21,3 +21,3 @@

				  def validate(%{"type" => type, "id" => _id} = data, meta)

				      when type in ["Person", "Organization", "Group", "Application"] do

				      when type in ["Person", "Organization", "Group", "Application", "Service"] do

floatingghost commented

2024-04-23 15:28:50 +00:00

you can probably use Pleroma.Constants.actor_types here to avoid any issues like this popping up again

Oneric commented

2024-04-23 15:56:29 +00:00

oh, id din’t knew we have this — but Pleroma.Constants.actor_types() ~~is still a function call~~ not a real compile-time constant so it can’t be used in a guard expression. uhhh, ex_const docs claim it already creates macros and those can be used in guards etc, but i get a compiler error when i try

Is there a way to access Pleroma.Constatnts stuff as actual constants?

oh, id din’t knew we have this — but `Pleroma.Constants.actor_types()` ~~is still a function call~~ not a real compile-time constant so it can’t be used in a guard expression. uhhh, `ex_const` docs claim it already creates macros and those can be used in guards etc, but i get a compiler error when i try Is there a way to access `Pleroma.Constatnts` stuff as _actual_ constants?

floatingghost commented

2024-04-23 16:01:44 +00:00

according to ex_const's docs, you can use them in guards

i'll have to check for myself if this works in reality though 🥴

according to [ex_const's docs](https://github.com/jcomellas/ex_const?tab=readme-ov-file#single-constants), you _can_ use them in guards i'll have to check for myself if this works in reality though 🥴

Oneric commented

2024-04-23 16:13:21 +00:00

ok, it actually does work when used correctly

i initially didn’t add require Pleroma.Constants and got a compiler error about “expected a compile-time constant” which confused me. Will push once tests finish

ok, it actually _does_ work when used correctly i initially didn’t add `require Pleroma.Constants` and got a compiler error about “expected a compile-time constant” which confused me. Will push once tests finish

floatingghost commented

2024-04-24 17:09:33 +00:00

i think it was added in the failed fetch processing PR we yoinked, so it's a new constant

Oneric marked this conversation as resolved

Oneric force-pushed all-actor-types from 25d267bc76 to 83f75c3e93

2024-04-23 16:16:45 +00:00

Compare

floatingghost commented

2024-04-24 17:08:58 +00:00

thankies~

floatingghost merged commit 764dbeded4 into develop

2024-04-24 17:09:02 +00:00

floatingghost deleted branch all-actor-types

2024-04-24 17:09:02 +00:00

floatingghost referenced this pull request from a commit

2024-04-24 17:09:03 +00:00

Merge pull request 'Accept all standard actor types' (#751) from Oneric/akkoma:all-actor-types into develop

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#751