ReceiverWorker: Make sure non-{:ok, _} is returned as {:error, …} #753

Merged

floatingghost merged 1 commit from Oneric/akkoma:receive-worker-return into develop 2024-04-24 17:00:18 +00:00

Conversation 1 Commits 1 Files changed 1 +2 -1

Oneric commented 2024-04-21 19:04:06 +00:00

Member

Copy link

Same thing as b7dd739de1 and afaict the only other worker where a wrong return is as obvious (if a worker just forwards the result from some other module’s function i didn’t check if the format will always match)

Cherry-picked-from: pleroma@a299ddb10e

Same thing as b7dd739de1ab2b7fab36429724f004dfa7b29440 and afaict the only other worker where a wrong return is as obvious *(if a worker just forwards the result from some other module’s function i didn’t check if the format will always match)* Cherry-picked-from: [`pleroma@a299ddb10e`](https://git.pleroma.social/pleroma/pleroma/-/commit/a299ddb10e5b682194710d97eed541277c9d22b6)

Oneric added 1 commit 2024-04-21 19:04:06 +00:00

ReceiverWorker: Make sure non-{:ok, _} is returned as {:error, …} ... 0c2f200b4d

Otherwise an error like `{:signature, {:error, {:error, :not_found}}}`
ends up considered a success.

Cherry-picked-from: a299ddb10e

floatingghost commented 2024-04-24 17:00:15 +00:00

Owner

Copy link

all good, thanks for pulling this in~

all good, thanks for pulling this in~

floatingghost merged commit 4a0e90e8a8 into develop 2024-04-24 17:00:18 +00:00

floatingghost deleted branch receive-worker-return 2024-04-24 17:00:18 +00:00

floatingghost referenced this pull request from a commit 2024-04-24 17:00:22 +00:00

Merge pull request 'ReceiverWorker: Make sure non-{:ok, _} is returned as {:error, …}' (#753) from Oneric/akkoma:receive-worker-return into develop

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

approved, awaiting change

  

bug

Something is not working

  

configuration

This requires config changes

  

documentation

This is about human-readable docs

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

extremely low priority

  

feature request

Something new?

  

Fix it yourself

Support has been attempted

  

help wanted

Need some help

  

invalid

Something is wrong

  

mastodon_api

  

needs docs

  

needs tests

  

not a bug

  

planned

  

pleroma_api

  

privacy

  

question

More information is needed

  

static_fe

  

triage

  

wontfix

This won't be fixed

No labels

approved, awaiting change

bug

configuration

documentation

duplicate

enhancement

extremely low priority

feature request

Fix it yourself

help wanted

invalid

mastodon_api

needs docs

needs tests

not a bug

planned

pleroma_api

privacy

question

static_fe

triage

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#753

No description provided.