ReceiverWorker: Make sure non-{:ok, _} is returned as {:error, …} #753

Merged

floatingghost merged 1 commits from Oneric/akkoma:receive-worker-return into develop

2024-04-24 17:00:18 +00:00

Oneric commented

2024-04-21 19:04:06 +00:00

Member

Same thing as b7dd739de1 and afaict the only other worker where a wrong return is as obvious (if a worker just forwards the result from some other module’s function i didn’t check if the format will always match)

Cherry-picked-from: pleroma@a299ddb10e

Same thing as b7dd739de1ab2b7fab36429724f004dfa7b29440 and afaict the only other worker where a wrong return is as obvious *(if a worker just forwards the result from some other module’s function i didn’t check if the format will always match)* Cherry-picked-from: [`pleroma@a299ddb10e`](https://git.pleroma.social/pleroma/pleroma/-/commit/a299ddb10e5b682194710d97eed541277c9d22b6)

Oneric added 1 commit 2024-04-21 19:04:06 +00:00

ci/woodpecker/pr/lint Pipeline was successful Details

ci/woodpecker/pr/test Pipeline was successful Details

ci/woodpecker/pr/build-arm64 unknown status Details

ci/woodpecker/pr/build-amd64 unknown status Details

ci/woodpecker/pr/docs unknown status Details

0c2f200b4d ReceiverWorker: Make sure non-{:ok, _} is returned as {:error, …}

Otherwise an error like `{:signature, {:error, {:error, :not_found}}}`
ends up considered a success.

Cherry-picked-from: a299ddb10e

floatingghost commented

2024-04-24 17:00:15 +00:00

Owner

all good, thanks for pulling this in~

floatingghost merged commit 4a0e90e8a8 into develop

2024-04-24 17:00:18 +00:00

floatingghost deleted branch receive-worker-return

2024-04-24 17:00:18 +00:00

floatingghost referenced this issue from a commit

2024-04-24 17:00:22 +00:00

Merge pull request 'ReceiverWorker: Make sure non-{:ok, _} is returned as {:error, …}' (#753) from Oneric/akkoma:receive-worker-return into develop

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#753

No description provided.