[bug] exiftool alt text generator includes stderr (?) #773

New issue

Closed

opened 2024-05-07 18:34:38 +00:00 by floatingghost · 1 comment

floatingghost commented

2024-05-07 18:34:38 +00:00

Owner

Your setup

From source

Extra details

No response

Version

No response

PostgreSQL version

No response

What were you trying to do?

logging so I remember

posted an image

What did you expect to happen?

the alt text not to have warnings from exiftool

What actually happened?

it did

Logs

https://media.ihatebeinga.live/media/d45d3c807ad65c399c027bc67a9fcaea43e6ccb7026432ea9ef4f6ff6884bd1c.png is the media in question

Severity

I can manage

Have you searched for this issue?

I have double-checked and have not found this issue mentioned anywhere.

### Your setup From source ### Extra details _No response_ ### Version _No response_ ### PostgreSQL version _No response_ ### What were you trying to do? logging so I remember posted an image ### What did you expect to happen? the alt text not to have warnings from exiftool ### What actually happened? it did ### Logs ```shell https://media.ihatebeinga.live/media/d45d3c807ad65c399c027bc67a9fcaea43e6ccb7026432ea9ef4f6ff6884bd1c.png is the media in question ``` ### Severity I can manage ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.

Screenshot_20240507_193232_Tusky.jpg

282 KiB

floatingghost added the

bug

label 2024-05-07 18:34:38 +00:00

Oneric commented

2024-05-08 00:12:21 +00:00

Member

heh, it currently explicitly redirects stderr to stdout:

stderr_to_stdout: true,

not sure why, maybe to keep exiftool warnings and errors out of Akkoma logs (and (as it turns out mistakenly) assuming anything printing something to stderr won't have a zero exit code)?

Just dropping this redirect probably fixes this. To avoid log spam -ignoreMinorErrors -q -q (two -q!) could be added

heh, it currently explicitly redirects stderr to stdout: https://akkoma.dev/AkkomaGang/akkoma/src/commit/ee03149ba1b53c8df83645b5a5249422ee1da50e/lib/pleroma/upload/filter/exiftool/read_description.ex#L37 not sure why, maybe to keep exiftool warnings and errors out of Akkoma logs (and (as it turns out mistakenly) assuming anything printing something to stderr won't have a zero exit code)? Just dropping this redirect probably fixes this. To avoid log spam `-ignoreMinorErrors -q -q` (_two_ `-q`!) could be added