Allow for attachment to be a single object in user data #783
No reviewers
Labels
No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: AkkomaGang/akkoma#783
Loading…
Reference in a new issue
No description provided.
Delete branch "single-attachment"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
single object or array is ok, anything else is a no go
looks good; one suggestion
on a tangential note looking at the CI failures, it seems the 10s tolerance in the recently added backoff test isn't quite enough (it was one second off) and i suspect the two
test creates new app with (default|custom) scopesfailures were also timing related given it complained about something not showing within a second@ -1550,3 +1554,4 @@data|> Map.get("attachment", [])|> normalize_attachment()|> Enum.filter(fn %{"type" => t} -> t == "PropertyValue" end)Just a though feel free to dismiss: in case an attachment list contains external objects minified to just their ID or something else entirely, it might be good to also change the filter to:
Then we’d only discard unsupported attachments rather than rejecting the entire actor. On the downside, dropped entries might take longer to spot increasing the time until a federation issue gets fixed; not sure how relevant though