AkkomaGang/akkoma
AkkomaGang/akkoma
13
63
Fork 84
Code Issues 163 Pull requests 17 Packages Projects 2 Releases 14 Wiki Activity

Raise minimum PostgreSQL version to 12 #786

Merged
floatingghost merged 3 commits from Oneric/akkoma:psql-min-ver into develop 2024-06-07 16:53:23 +00:00
Conversation 8 Commits 3 Files changed 7 +26 -108
Oneric commented 2024-05-30 23:58:56 +00:00
Member
Copy link

PostgreSQL 11 is EOL since 2023-11-09.
Dropping it lets us simplify search code a bit and avoids the hash index problem for PSQL<10 brought up in #765.

PostgreSQL 11 is EOL [since 2023-11-09](https://www.postgresql.org/support/versioning/). Dropping it lets us simplify search code a bit and avoids the hash index problem for PSQL<10 brought up in #765.
Oneric added 2 commits 2024-05-30 23:58:57 +00:00 
This lets us get rid off a runtime check and avoids problems with hash
indices being unsafe and broken before version 10. We currently don't
have any hash indices, but might soon™ add some.

Even PostgreSQL 11 is already EOL since 2023-11-09,
so this shouldn’t actually impact anyone.
Raise log level for start failures
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending
Details
ci/woodpecker/pr/docs Pipeline is pending
Details
ci/woodpecker/pr/lint Pipeline is pending
Details
ci/woodpecker/pr/test Pipeline is pending
Details
610a138845
norm commented 2024-05-31 06:21:05 +00:00
Contributor
Copy link

Might as well raise the minimum to 12 (which still seems to be supported until 2024-11-14) so that we can have this option enabled by default: https://docs.akkoma.dev/stable/configuration/postgresql/#disable-generic-query-plans

Might as well raise the minimum to 12 (which still seems to be supported until 2024-11-14) so that we can have this option enabled by default: https://docs.akkoma.dev/stable/configuration/postgresql/#disable-generic-query-plans
floatingghost commented 2024-05-31 14:13:49 +00:00
Owner
Copy link

honestly yeah, even debian oldstable is pgsql 13 - we can push to that just fine i think

honestly yeah, even debian oldstable is pgsql 13 - we can push to that just fine i think
Oneric changed title from Raise minimum PostgreSQL version to 11 to Raise minimum PostgreSQL version to 12 2024-05-31 15:07:15 +00:00
Oneric force-pushed psql-min-ver from 610a138845 to 95531eca68 2024-05-31 15:11:54 +00:00 Compare
Oneric commented 2024-05-31 15:12:33 +00:00
Author
Member
Copy link

Neat, didn’t know about that option. Now bumping to 12 and setting the custom plan option; since startup fails with an illegal value, it seems like it does take effect.

Does bumping to 13 enable anything further? I only know of 12’s query planer sometimes producing worse results but nothing which holds newer versions back (in the linked case, things are already supposed to work without using a cross join anyway)

Neat, didn’t know about that option. Now bumping to 12 and setting the custom plan option; since startup fails with an illegal value, it seems like it does take effect. Does bumping to 13 enable anything further? I only know of 12’s query planer [sometimes producing worse results](https://akkoma.dev/AkkomaGang/akkoma/issues/650#issuecomment-11931) but nothing which holds newer versions back *(in the linked case, things are already _supposed_ to work without using a cross join anyway)*
norm commented 2024-06-02 20:32:19 +00:00
Contributor
Copy link

13 seems to mostly contain performance improvements and better query planning, but otherwise I don't really think there's something that seems to stand out in terms of features that would greatly benefit Akkoma.
https://www.postgresql.org/docs/13/release-13.html

Bumping to 13 would mean those that are still running Ubuntu 20.04 would need to upgrade or switch to another repo since it has Postgres 12 in the default repos, but I don't really know how many people still use it with Akkoma.

13 seems to mostly contain performance improvements and better query planning, but otherwise I don't really think there's something that seems to stand out in terms of features that would greatly benefit Akkoma. https://www.postgresql.org/docs/13/release-13.html Bumping to 13 would mean those that are still running Ubuntu 20.04 would need to upgrade or switch to another repo since it has Postgres 12 in the default repos, but I don't really know how many people still use it with Akkoma.
floatingghost commented 2024-06-07 13:00:08 +00:00
Owner
Copy link

heh ok merge conflicto, hooray

heh ok merge conflicto, hooray
Oneric force-pushed psql-min-ver from 95531eca68 to b405229612 2024-06-07 13:56:34 +00:00 Compare
Oneric commented 2024-06-07 13:57:38 +00:00
Author
Member
Copy link

rebased

rebased
Oneric force-pushed psql-min-ver from b405229612 to 2180d068ae 2024-06-07 14:21:29 +00:00 Compare
Oneric commented 2024-06-07 14:22:59 +00:00
Author
Member
Copy link

And force-pushed again to add a changelog entry and for this also cherry-picking the changelog unmangling from #789

And force-pushed again to add a changelog entry and for this also cherry-picking the changelog unmangling from #789
floatingghost commented 2024-06-07 16:53:18 +00:00
Owner
Copy link

thankies~

thankies~
floatingghost merged commit d1c4b97613 into develop 2024-06-07 16:53:23 +00:00
floatingghost deleted branch psql-min-ver 2024-06-07 16:53:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#786
No description provided.
Delete branch "Oneric/akkoma:psql-min-ver"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?