AkkomaGang/akkoma
AkkomaGang/akkoma
15
65
Fork 92
Code Issues 176 Pull requests 24 Projects 2 Releases 14 Packages Wiki Activity

Fix fs error while unpacking frontends #839

Merged
floatingghost merged 1 commit from tudbut/akkoma:frontends into develop 2024-10-26 03:58:41 +00:00
Conversation 2 Commits 1 Files changed 1 +4
tudbut commented 2024-10-18 12:52:31 +00:00
Contributor
Copy link

Fixes: #836

The zip file contains directory items, which get read as if they were regular files. They then get created as empty files and block items from going inside.

Fixes: #836 The zip file contains directory items, which get read as if they were regular files. They then get created as empty files and block items from going inside.
tudbut added 1 commit 2024-10-18 12:52:32 +00:00
fix fs error while unpacking frontends
Some checks failed
ci/woodpecker/pr/lint Pipeline failed
Details
ci/woodpecker/pr/test unknown status
Details
ci/woodpecker/pr/build-arm64 unknown status
Details
ci/woodpecker/pr/build-amd64 unknown status
Details
ci/woodpecker/pr/docs unknown status
Details
8b5aca9619
floatingghost commented 2024-10-18 17:16:58 +00:00
Owner
Copy link

so fun fact i did some investigation

the source of this error is OTP 27.1 (released last month) - https://www.erlang.org/news/171#highlights

which changes the behaviour of :zip

we may have to be very careful here that we don't break older OTP compat

so fun fact i did some investigation the source of this error is OTP 27.1 (released last month) - https://www.erlang.org/news/171#highlights which changes the behaviour of `:zip` we may have to be very careful here that we don't break older OTP compat
floatingghost commented 2024-10-26 03:58:36 +00:00
Owner
Copy link

yep, works on OTP26 as well - thanks a lot!

just for future info, it's usually good practice to run mix format before opening a PR just to catch any linting issues - in this case there's just a rogue space, i'll fix it after merge

yep, works on OTP26 as well - thanks a lot! just for future info, it's usually good practice to run `mix format` before opening a PR just to catch any linting issues - in this case there's just a rogue space, i'll fix it after merge
❤️ 1
floatingghost merged commit 98a3dab10a into develop 2024-10-26 03:58:41 +00:00
floatingghost deleted branch frontends 2024-10-26 03:58:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#839
No description provided.
Delete branch "tudbut/akkoma:frontends"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?