Fix fs error while unpacking frontends #839

Merged
floatingghost merged 1 commit from tudbut/akkoma:frontends into develop 2024-10-26 03:58:41 +00:00
Contributor

Fixes: #836

The zip file contains directory items, which get read as if they were regular files. They then get created as empty files and block items from going inside.

Fixes: #836 The zip file contains directory items, which get read as if they were regular files. They then get created as empty files and block items from going inside.
tudbut added 1 commit 2024-10-18 12:52:32 +00:00
fix fs error while unpacking frontends
Some checks failed
ci/woodpecker/pr/lint Pipeline failed
ci/woodpecker/pr/test unknown status
ci/woodpecker/pr/build-arm64 unknown status
ci/woodpecker/pr/build-amd64 unknown status
ci/woodpecker/pr/docs unknown status
8b5aca9619

so fun fact i did some investigation

the source of this error is OTP 27.1 (released last month) - https://www.erlang.org/news/171#highlights

which changes the behaviour of :zip

we may have to be very careful here that we don't break older OTP compat

so fun fact i did some investigation the source of this error is OTP 27.1 (released last month) - https://www.erlang.org/news/171#highlights which changes the behaviour of `:zip` we may have to be very careful here that we don't break older OTP compat

yep, works on OTP26 as well - thanks a lot!

just for future info, it's usually good practice to run mix format before opening a PR just to catch any linting issues - in this case there's just a rogue space, i'll fix it after merge

yep, works on OTP26 as well - thanks a lot! just for future info, it's usually good practice to run `mix format` before opening a PR just to catch any linting issues - in this case there's just a rogue space, i'll fix it after merge
floatingghost merged commit 98a3dab10a into develop 2024-10-26 03:58:41 +00:00
floatingghost deleted branch frontends 2024-10-26 03:58:41 +00:00
Sign in to join this conversation.
No description provided.