MediaProxy omits inline imaged without explicit scheme #900

New issue

Closed

opened 2025-04-09 19:14:09 +00:00 by Oneric · 0 comments

Oneric commented

2025-04-09 19:14:09 +00:00

Owner

Your setup

From source

Version

3.15.1-1 (522a168a)

What is wrong?

Inline images without an explicit URL scheme will not be proxied even with media proxy enabled.
If media proxy was enabled with the goal of improving the anonymity of local users, the resulting IP leak is undesireable.

Example: https://cofe.rocks/notice/AsvC1Xh4OJQB7z3AcC

"content": "'let&#39;s see if this works\n<br/><br/>\n<img src="//uploads.cofe.rocks/a.png"/>'"

This is probably a consequence of #860 although I’m not sure if it was proxied successfully before or just errored out (if the redirect_on_failure default value was explicitly overriden to true, it would have leaked the IP even before, but in the default config this shouldn’t have happened previously)

Possible fix

without explicit scheme just assume HTTPS and attempt proxying

Severity

I cannot use it as easily as I'd like

Have you searched for this issue?

I have double-checked and have not found this issue mentioned anywhere.

### Your setup From source ### Version 3.15.1-1 (522a168a) ### What is wrong? Inline images without an explicit URL scheme will not be proxied even with media proxy enabled. If media proxy was enabled with the goal of improving the anonymity of local users, the resulting IP leak is undesireable. Example: https://cofe.rocks/notice/AsvC1Xh4OJQB7z3AcC ```json "content": "'let's see if this works\n<br/><br/>\n<img src="//uploads.cofe.rocks/a.png"/>'" ``` This is probably a consequence of https://akkoma.dev/AkkomaGang/akkoma/pulls/860 although I’m not sure if it was proxied successfully before or just errored out *(if the `redirect_on_failure` default value was explicitly overriden to `true`, it would have leaked the IP even before, but in the default config this shouldn’t have happened previously)* ### Possible fix without explicit scheme just assume HTTPS and attempt proxying ### Severity I cannot use it as easily as I'd like ### Have you searched for this issue? - [x] I have double-checked and have not found this issue mentioned anywhere.