AkkomaGang/akkoma
AkkomaGang/akkoma
17
70
Fork 112
Code Issues 151 Pull requests 20 Projects 2 Releases 21 Packages Wiki Activity

Support Mastodon-compatible translations API #1024

Merged
Oneric merged 4 commits from mkljczk/akkoma:akkoma-mastoapi-translations into develop 2026-01-04 16:11:28 +00:00
Conversation 2 Commits 4 Files changed 15 +275 -48
mkljczk commented 2025-11-28 09:03:21 +00:00
Contributor
Copy link

Signed-off-by: nicole mikołajczyk git@mkljczk.pl

Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
Support Mastodon-compatible translations API
Some checks are pending
ci/woodpecker/pr/test/1 Pipeline is pending approval
Details
ci/woodpecker/pr/test/2 Pipeline is pending approval
Details
ebfb00f5c2 
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
Oneric reviewed 2025-11-30 00:25:31 +00:00
lib/pleroma/akkoma/translators/libre_translate.ex Outdated
@ -1,6 +1,8 @@
defmodule Pleroma.Akkoma.Translators.LibreTranslate do
@behaviour Pleroma.Akkoma.Translator
@name LibreTranslate
Oneric commented 2025-11-28 17:47:35 +00:00
Owner
Copy link

Missing quotes to make this a string.
But why use constants here anyway if its only purpose is to be returned from one, single getter function?

Missing quotes to make this a string. But why use constants here anyway if its only purpose is to be returned from one, single getter function?
mkljczk marked this conversation as resolved
lib/pleroma/web/mastodon_api/controllers/status_controller.ex Outdated
@ -500,0 +504,4 @@
%Activity{} = activity <- Activity.get_by_id_with_object(id),
{:visible, true} <- {:visible, Visibility.visible_for_user?(activity, user)},
translation_module <- Config.get([:translator, :module]),
{:ok, detected, translation} <-
Oneric commented 2025-11-28 17:52:59 +00:00
Owner
Copy link

90% of the code here is just duplicated. The only difference is the way initial parameters are acquired and the slightly different output on success. I think this should be deduplicated with a private function

90% of the code here is just duplicated. The only difference is the way initial parameters are acquired and the slightly different output on success. I think this should be deduplicated with a private function
👍 1
mkljczk marked this conversation as resolved
mkljczk force-pushed akkoma-mastoapi-translations from ebfb00f5c2
Some checks are pending
ci/woodpecker/pr/test/1 Pipeline is pending approval
Details
ci/woodpecker/pr/test/2 Pipeline is pending approval
Details
to 24ab1d6545 2025-12-15 22:33:58 +00:00 Compare 
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
mkljczk force-pushed akkoma-mastoapi-translations from 564f979b94 to f2e571173b 2025-12-15 23:01:23 +00:00 Compare
Oneric force-pushed akkoma-mastoapi-translations from f2e571173b to b147d2b19d
All checks were successful
ci/woodpecker/pr/test/2 Pipeline was successful
Details
ci/woodpecker/pr/test/1 Pipeline was successful
Details
2026-01-04 15:49:06 +00:00 Compare
Oneric commented 2026-01-04 16:11:11 +00:00
Owner
Copy link

Thanks, seems good to me now and passes CI!

Thanks, seems good to me now and passes CI!
Oneric merged commit e941f8c7c1 into develop 2026-01-04 16:11:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
broken setup

Issue arose from a misconfiguration by the admin, custom patches, manual db edits or similar

  
bug

Something is not working

  
cannot reproduce

   
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs change/feedback

Issue or PR is stalled on response from the author or a third party

  
needs docs

   
needs tests

   
not a bug

   
not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
broken setup
bug
cannot reproduce
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs change/feedback
needs docs
needs tests
not a bug
not our bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AkkomaGang/akkoma!1024
No description provided.