Various fixes #1043

Merged

Oneric merged 5 commits from Oneric/akkoma:varfixes into develop 2026-01-05 14:38:33 +00:00

Conversation 0 Commits 5 Files changed 14 +212 -64

Oneric commented 2026-01-05 03:24:52 +00:00

Owner

Copy link

Pulled out some conversation-unrealted fixes from the conversations API PR, a fix ported from Pleroma for leaking follow* counts in stream events I didn’t push yet and added a fix for #1042.

I was also considering porting https://git.pleroma.social/pleroma/pleroma/-/merge_requests/4032 due to delaying streaming out of notifications only after the side-effect transaction went through being desirable (to avoid duplicates and ghost notifications when processing temporarily or permanently fails, and to not stall the db transaction with network activity).
However, this PR also breaks the with_muted=true parameter of the notifications endpoint by not creating notifications for muted users/threads at all (currently they are created but not send out). Thus this is deferred for now

Pulled out some conversation-unrealted fixes from the conversations API PR, a fix ported from Pleroma for leaking follow* counts in stream events I didn’t push yet and added a fix for #1042. I was also considering porting https://git.pleroma.social/pleroma/pleroma/-/merge_requests/4032 due to delaying streaming out of notifications only _after_ the side-effect transaction went through being desirable *(to avoid duplicates and ghost notifications when processing temporarily or permanently fails, and to not stall the db transaction with network activity)*. However, this PR also breaks the `with_muted=true` parameter of the notifications endpoint by not creating notifications for muted users/threads at all *(currently they are created but not send out)*. Thus this is deferred for now

Oneric added 5 commits 2026-01-05 03:24:53 +00:00

web/activity_pub: drop duplicated restrict_filtered d045be8450

api/v1/filters: escape regex sequence in user-provided phrases ef97491bbc

api/pleroma/conversation: accept JSON body to update conversation f1e1760a90

api/stream: don’t leak hidden follow* counts in relationship updates ... e01da3d2f1

Based on the Pleroma patch linked below, but not needlessly
hiding the count if only the listing of the specific follow* accounts is
hidden while counts are still public.
https://git.pleroma.social/pleroma/pleroma/-/merge_requests/4205

Co-authored-by: nicole mikołajczyk <git@mkljczk.pl>

fed/out: also represent emoji as anonymous objects in reactions ... 0fa6c0cb90

It did not use the same Emoji object template as other occurrences.
This also fixes an issue with the icon URL not being properly encoded
as well as an inconsistency regarding the domain part of remote
reactions in retractions. All places use the image URL domain
except the query to find the activity to retract relie on the id.
Even before this change this made it impossible to retract remote
emoji reactions if the remote either doesn't send emoji IDs or
doesn't store images on the ActivityPub domain.

Addresses omission in 4ff5293093

Fixes: #1042

Oneric force-pushed varfixes from 0fa6c0cb90 to d5b4d8f09e 2026-01-05 03:25:35 +00:00 Compare

Oneric force-pushed varfixes from d5b4d8f09e to 83176e9042 2026-01-05 03:34:57 +00:00 Compare

Oneric force-pushed varfixes from 83176e9042 to 80817ac65e 2026-01-05 04:02:14 +00:00 Compare

Oneric merged commit e326285085 into develop 2026-01-05 14:38:33 +00:00

Oneric deleted branch varfixes 2026-01-05 14:38:33 +00:00

Oneric referenced this pull request from a commit 2026-01-05 14:38:33 +00:00

Merge pull request 'Various fixes' (#1043) from Oneric/akkoma:varfixes into develop

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

approved, awaiting change

  

bug

Something is not working

  

cannot reproduce

  

configuration

This requires config changes

  

documentation

This is about human-readable docs

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

extremely low priority

  

feature request

Something new?

  

Fix it yourself

Support has been attempted

  

help wanted

Need some help

  

invalid

Something is wrong

  

mastodon_api

  

needs change/feedback

Issue or PR is stalled on response from the author or a third party

  

needs docs

  

needs tests

  

not a bug

  

not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  

planned

  

pleroma_api

  

privacy

  

question

More information is needed

  

static_fe

  

triage

  

wontfix

This won't be fixed

No labels

approved, awaiting change

bug

cannot reproduce

configuration

documentation

duplicate

enhancement

extremely low priority

feature request

Fix it yourself

help wanted

invalid

mastodon_api

needs change/feedback

needs docs

needs tests

not a bug

not our bug

planned

pleroma_api

privacy

question

static_fe

triage

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

AkkomaGang/akkoma!1043

No description provided.