webfinger: accept canoncial AP type in XML and don’t serve response for remote users #1045

Merged

Oneric merged 3 commits from Oneric/akkoma:fix-webfinger-type into develop

2026-01-10 20:23:54 +00:00

Oneric commented

2026-01-10 19:14:25 +00:00

Owner

JSON already parses both the canonical and Mastodon type, but for inexplicable reasons a failed (code was bugged and a noop) attempt at doing this in XML too was pulled (within the same PR introducing it; no review comments; see commit message).

When using qualified nicknames it was already restricted to local accounts, but AP ids were left unchecked.

JSON already parses both the canonical and Mastodon type, but for inexplicable reasons a failed *(code was bugged and a noop)* attempt at doing this in XML too was pulled *(within the same PR introducing it; no review comments; see commit message)*. When using qualified nicknames it was already restricted to local accounts, but AP ids were left unchecked.

Oneric added 3 commits

2026-01-10 19:14:26 +00:00

fed/in: accept canoncial AP type in XML webfinger data ee7e6d87f2

This was supposed to be already handled for both XML and JSON
with d1f6ecf607 though the code
failed to consider variable scopes and thus was broken and
actually just a noop for XML.

For inexplicable reasons 1a250d65af
just outright removed both the failed attempt to parse the canonical
type in XML documents and also serving of the canonical type in our own
XML (and only XML) response.

With the refactor in 28f7f4c6de
the canoncial type was again served in both our own JSON and XML
responses but parsing of the canonical type remained missing
from XML until now.

webfinger: mark represent_user as private 967e2d0e71

webfinger: don’t serve response for remote users’ AP id

ci/woodpecker/pr/test/2 Pipeline was successful

Details

ci/woodpecker/pr/test/1 Pipeline was successful

Details

74fa8f5581