AkkomaGang/akkoma
AkkomaGang/akkoma
17
70
Fork 115
Code Issues 147 Pull requests 16 Projects 2 Releases 23 Packages Wiki Activity

ensure utf-8 nicknames on nickname GETs and user validator #1057

Merged
floatingghost merged 4 commits from user-utf8 into develop 2026-02-07 19:41:27 +00:00
Conversation 2 Commits 4 Files changed 3 +11
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 3deb267333 - Show all commits

if we don't have a preferredUsername, accept standard fallback

Prev Next
FloatingGhost 2026-01-25 01:30:25 +00:00
commit 3deb267333

11
lib/pleroma/web/activity_pub/object_validators/user_validator.ex
View file

@ -25,6 +25,7 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.UserValidator do
when type in Pleroma.Constants.actor_types() do
with :ok <- validate_pubkey(data),
:ok <- validate_inbox(data),
:ok <- validate_nickname(data),
:ok <- contain_collection_origin(data) do
{:ok, data, meta}
else
@ -83,4 +84,14 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.UserValidator do
_, error -> error
end)
end
defp validate_nickname(%("preferredUsername" => nick)) when is_binary(nick) do
Oneric marked this conversation as resolved
Oneric commented 2026-01-25 15:33:29 +00:00
Copy link

what will happen if "preferredusername" exists but isn’t a binary?

what will happen if `"preferredusername"` exists but isn’t a binary?
floatingghost commented 2026-02-07 19:09:36 +00:00
Copy link

updated to error if we have the preferredUsername key but its type is silly

updated to error if we have the preferredUsername key but its type is silly
if String.valid?(nick) do
:ok
else
{:error, "Nickname is not valid UTF-8"}
end
end
defp validate_nickname(_), do: :ok
end