AkkomaGang/akkoma
AkkomaGang/akkoma
17
70
Fork 115
Code Issues 147 Pull requests 16 Projects 2 Releases 23 Packages Wiki Activity

Add sane defaults for database_config_whitelist, add a task to remove non-whitelisted configs #1077

Merged
floatingghost merged 13 commits from mkljczk/akkoma:akkoma-database-config-whitelist into develop 2026-04-01 10:38:31 +00:00
Conversation 2 Commits 13 Files changed 8 +187 -2
mkljczk commented 2026-03-02 23:20:47 +00:00
Contributor
Copy link
No description provided. 
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
Update test and config for Akkoma
Some checks are pending
ci/woodpecker/pr/test/1 Pipeline is pending approval
Details
ci/woodpecker/pr/test/2 Pipeline is pending approval
Details
1721746ece 
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
This shouldn't be an error
Some checks are pending
ci/woodpecker/pr/test/1 Pipeline is pending approval
Details
ci/woodpecker/pr/test/2 Pipeline is pending approval
Details
f70eb0127e 
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
Oneric reviewed 2026-03-06 17:02:22 +00:00
Oneric left a comment
Owner
Copy link

I don’t use and aren’t too familiar with db config, so I’ll leave proper review and merge for others.
However I already noticed that one of the whitelisted section simply doesn’t exist, indicating this default cherry-picked from Pleroma might need (possibly more than this one removal) adjustments for Akkoma

I don’t use and aren’t too familiar with db config, so I’ll leave proper review and merge for others. However I already noticed that one of the whitelisted section simply doesn’t exist, indicating this default cherry-picked from Pleroma might need (possibly more than this one removal) adjustments for Akkoma
config/config.exs Outdated
@ -569,0 +571,4 @@
{:cors_plug},
{:ex_aws, :s3},
{:mime},
{:prometheus, Pleroma.Web.Endpoint.MetricsExporter},
Oneric commented 2026-03-06 16:59:39 +00:00
Owner
Copy link

this config section does not exist

this config section does not exist
mkljczk commented 2026-03-06 17:49:17 +00:00
Author
Contributor
Copy link

I recall checking whether this group is present in Akkoma and I thought I removed it before committing…

I recall checking whether this group is present in Akkoma and I thought I removed it before committing…
Oneric marked this conversation as resolved
Update default config
Some checks are pending
ci/woodpecker/pr/test/1 Pipeline is pending approval
Details
ci/woodpecker/pr/test/2 Pipeline is pending approval
Details
a14d405e78 
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
floatingghost approved these changes 2026-04-01 10:38:10 +00:00
floatingghost left a comment
Owner
Copy link

i do use DB config extensively, and this seems good to me

i'm happy to take this as-is and fix the changelog thingy myself, works on ihba - thanks!

i do use DB config extensively, and this seems good to me i'm happy to take this as-is and fix the changelog thingy myself, works on ihba - thanks!
changelog.d/database-config-whitelist.add
@ -0,0 +1 @@
Add reasonable defaults for :database_config_whitelist
floatingghost commented 2026-04-01 10:32:44 +00:00
Owner
Copy link

extremely minor, we use the old changelog format rather than the new changelog.d

extremely minor, we use the old changelog format rather than the new changelog.d
floatingghost deleted branch akkoma-database-config-whitelist 2026-04-01 10:38:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
floatingghost
Labels
Clear labels   
approved, awaiting change

   
broken setup

Issue arose from a misconfiguration by the admin, custom patches, manual db edits or similar

  
bug

Something is not working

  
cannot reproduce

   
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs change/feedback

Issue or PR is stalled on response from the author or a third party

  
needs docs

   
needs tests

   
not a bug

   
not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
broken setup
bug
cannot reproduce
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs change/feedback
needs docs
needs tests
not a bug
not our bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AkkomaGang/akkoma!1077
No description provided.