Create contributor guidelines #1100
No reviewers
Labels
No labels
approved, awaiting change
broken setup
bug
cannot reproduce
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs change/feedback
needs docs
needs tests
not a bug
not our bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AkkomaGang/akkoma!1100
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "contributing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A basic first policy - i think this covers what we'd want to cover
that is mostly that we need to be certain of the provenance and correctness of PRs sent to us
Regarding the AI policy, I think it’s fine.
As with any policy it could ofc be endlessly bikeshed about the right level of verbosity, whether or which motivations to include, potential edge cases etc. But in the end, this is not some stringent, blindly applied law and sensible enforcement is up to maintainers and ultimately the project leader (i.e. you) anyway. (Meaning: it doesn’t need to hold up to malicious by-the-letter interpretations)
Trying to explain the reasoning and focussing on the aspects most directly relevant to Akkoma and the patch submission process itself is one way to go about it and might clear up the intent while if anyone tries to weasle another interpretation out of it we can still reject it anyway.
However, since the file is
CONTRIBUTING.mdand pointed at for any kind of contribution in our readme, I think it should include a bit more.For one, contributors are ofc also expected to follow our code of conduct to keep the community environment welcoming. Meaning there should be a pointer to
CODE_OF_CONDUCT.md.Furthermore we already have (though possibly somewhat dated) “getting started” instructions for new contributors in
docs/docs/development/index.mdand other doc files it points at. (It currently mentions writing tests, but not explicitly encourages running the full test suite on patch sets: It probably should). This too would be good to reference.oh also: maybe it be good to point out in the doc page (or
CONTRIBUTING.mddirectly?), that large changes (e.g. affecting the db scheme more significantly than a simple new column; or similarly the processing pipeline; etc) should best first discuss the approach either in the IRC channel or as an RFC issue to make sure it fits in with current architecture and planned future changes and to avoid unnecessarily wasting work on subpar approaches or in case the feature is not desired at all(as a side effect, if prospective contributors first explain and reason about the concept (and the "reasoning" isn’t just LLM slop itself), they actually must have put some thought into it)
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.