fix flaky test filter_controller_test.exs:200 #239
No reviewers
Labels
No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: AkkomaGang/akkoma#239
Loading…
Reference in New Issue
No description provided.
Delete Branch "ilja/akkoma:fix_flaky_filter_controller_test.exs_200"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The flakyness was actually already fixed by adding a timediff. But here I'm mocking time which gives a more precise test. It does require the test to be sync. I add this PR here to be complete, feel free to discard if you think the current sollution was better/already good enough.
yeah i think i agree with you here, whilst the last solution does work, it does still rely on the system clock which is bound to go weird at points