URL encode remote emoji pack names #362

Merged
floatingghost merged 1 commits from nbsp/akkoma:fix/emojipack-url into develop 2023-01-15 18:14:04 +00:00
Contributor

fix #246

fix #246
nbsp changed title from URL encode remote emoji pack names to WIP: URL encode remote emoji pack names 2022-12-10 22:55:01 +00:00
nbsp force-pushed fix/emojipack-url from f5e2e40b59 to f8cd122871 2022-12-10 23:31:22 +00:00 Compare
nbsp changed title from WIP: URL encode remote emoji pack names to URL encode remote emoji pack names 2022-12-10 23:31:28 +00:00
floatingghost requested changes 2022-12-14 02:58:13 +00:00
floatingghost left a comment
Owner

whilst the change is ok, this 100% needs a test to assert it works

whilst the change is ok, this 100% needs a test to assert it works
floatingghost added the
needs tests
label 2022-12-14 10:48:51 +00:00
nbsp force-pushed fix/emojipack-url from f8cd122871 to ec69c28fc8 2022-12-30 09:55:38 +00:00 Compare
nbsp force-pushed fix/emojipack-url from ec69c28fc8 to f9f8bbc95b 2022-12-30 10:00:48 +00:00 Compare
nbsp requested review from floatingghost 2022-12-30 10:10:11 +00:00

yep, this looks much better now

thanks!

yep, this looks much better now thanks!
floatingghost merged commit 20cd8a0fc4 into develop 2023-01-15 18:14:04 +00:00
floatingghost deleted branch fix/emojipack-url 2023-01-15 18:14:04 +00:00
Sign in to join this conversation.
No description provided.