AkkomaGang/akkoma
AkkomaGang/akkoma
17
68
Fork 110
Code Issues 145 Pull requests 16 Projects 2 Releases 21 Packages Wiki Activity

Use same context for quote posts as the post that's being quoted #379

Merged
floatingghost merged 1 commit from ilja/akkoma:quotes_same_context_as_quoted_post into develop 2022-12-31 18:09:28 +00:00
Conversation 2 Commits 1 Files changed 4 +7 -4
ilja commented 2022-12-17 16:12:13 +00:00
Contributor
Copy link

See #350 (comment)

When making quotes through Mast-API, they will now have the same context as the quoted post. This also results in them being showed when fetching the thread. I checked Misskey to see how it's there, and they show the quotes there as well, see e.g. https://mk.toast.cafe/notes/98u1g0tulg.

An example from Akkoma:

See https://akkoma.dev/AkkomaGang/akkoma/pulls/350#issuecomment-6109 When making quotes through Mast-API, they will now have the same context as the quoted post. This also results in them being showed when fetching the thread. I checked Misskey to see how it's there, and they show the quotes there as well, see e.g. <https://mk.toast.cafe/notes/98u1g0tulg>. An example from Akkoma:
Screenshot_20221217_171044.png
76 KiB
Screenshot_20221217_171044.png
ilja force-pushed quotes_same_context_as_quoted_post from 3fe6c121bd
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
to 2ecbbe123c
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
2022-12-17 16:34:46 +00:00 Compare
floatingghost approved these changes 2022-12-30 02:56:22 +00:00
floatingghost left a comment
Owner
Copy link

you've got a conflict in the changelog (sorry), but otherwise this looks good~

will merge when that's resolved

you've got a conflict in the changelog (sorry), but otherwise this looks good~ will merge when that's resolved
ilja force-pushed quotes_same_context_as_quoted_post from 2ecbbe123c
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
to 1def175d40
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
2022-12-31 11:29:32 +00:00 Compare
floatingghost commented 2022-12-31 18:09:17 +00:00
Owner
Copy link

we'll think about the reply-with-a-different-context at another point i guess

i don't suppose it matters much though

we'll think about the reply-with-a-different-context at another point i guess i don't suppose it matters much though
floatingghost deleted branch quotes_same_context_as_quoted_post 2022-12-31 18:09:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
floatingghost
Labels
Clear labels   
approved, awaiting change

   
broken setup

Issue arose from a misconfiguration by the admin, custom patches, manual db edits or similar

  
bug

Something is not working

  
cannot reproduce

   
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs change/feedback

Issue or PR is stalled on response from the author or a third party

  
needs docs

   
needs tests

   
not a bug

   
not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
broken setup
bug
cannot reproduce
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs change/feedback
needs docs
needs tests
not a bug
not our bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AkkomaGang/akkoma!379
No description provided.