AkkomaGang/akkoma
AkkomaGang
/
akkoma
12
63
Fork 83
Code Issues 173 Pull Requests 20 Packages Projects 2 Releases 12 Wiki Activity

Use same context for quote posts as the post that's being quoted #379

Merged
floatingghost merged 1 commits from ilja/akkoma:quotes_same_context_as_quoted_post into develop 2022-12-31 18:09:28 +00:00
Conversation 1 Commits 1 Files Changed 4 +7 -4
ilja commented 2022-12-17 16:12:13 +00:00
Contributor
Copy Link

See #350 (comment)

When making quotes through Mast-API, they will now have the same context as the quoted post. This also results in them being showed when fetching the thread. I checked Misskey to see how it's there, and they show the quotes there as well, see e.g. https://mk.toast.cafe/notes/98u1g0tulg.

An example from Akkoma:

See https://akkoma.dev/AkkomaGang/akkoma/pulls/350#issuecomment-6109 When making quotes through Mast-API, they will now have the same context as the quoted post. This also results in them being showed when fetching the thread. I checked Misskey to see how it's there, and they show the quotes there as well, see e.g. <https://mk.toast.cafe/notes/98u1g0tulg>. An example from Akkoma:
Screenshot_20221217_171044.png
76 KiB
Screenshot_20221217_171044.png
ilja force-pushed quotes_same_context_as_quoted_post from 3fe6c121bd to 2ecbbe123c 2022-12-17 16:34:46 +00:00 Compare
floatingghost approved these changes 2022-12-30 02:56:22 +00:00
floatingghost left a comment
Owner
Copy Link

you've got a conflict in the changelog (sorry), but otherwise this looks good~

will merge when that's resolved

you've got a conflict in the changelog (sorry), but otherwise this looks good~ will merge when that's resolved
floatingghost added the
approved, awaiting change
 label 2022-12-30 02:57:03 +00:00
ilja force-pushed quotes_same_context_as_quoted_post from 2ecbbe123c to 1def175d40 2022-12-31 11:29:32 +00:00 Compare
floatingghost commented 2022-12-31 18:09:17 +00:00
Owner
Copy Link

we'll think about the reply-with-a-different-context at another point i guess

i don't suppose it matters much though

we'll think about the reply-with-a-different-context at another point i guess i don't suppose it matters much though
floatingghost merged commit 745e15468e into develop 2022-12-31 18:09:28 +00:00
floatingghost deleted branch quotes_same_context_as_quoted_post 2022-12-31 18:09:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
floatingghost
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#379
No description provided.
Delete Branch "ilja/akkoma:quotes_same_context_as_quoted_post"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?