Use actual ISO8601 timestamps for masto API #425

Merged
floatingghost merged 2 commits from darkkirb/akkoma:fix-invalid-datetime into develop 2023-01-09 22:12:29 +00:00
2 changed files with 18 additions and 3 deletions
Showing only changes of commit 2ce4f96f6e - Show all commits

View File

@ -328,9 +328,16 @@ defmodule Pleroma.Web.CommonAPI.Utils do
end
def to_masto_date(%NaiveDateTime{} = date) do
date
|> NaiveDateTime.to_iso8601()
|> String.replace(~r/(\.\d+)?$/, ".000Z", global: false)
# NOTE: Elixirs ISO 8601 format is a superset of the real standard
# It supports negative years for example.
# ISO8601 only supports years before 1583 with mutual agreement
if date.year < 1583 do
""
else
date
|> NaiveDateTime.to_iso8601()
|> String.replace(~r/(\.\d+)?$/, ".000Z", global: false)
end
end
def to_masto_date(date) when is_binary(date) do

View File

@ -498,6 +498,14 @@ defmodule Pleroma.Web.CommonAPI.UtilsTest do
test "returns empty string when date invalid" do
assert Utils.to_masto_date("2015-01?23T23:50:07.123Z") == ""
end
test "returns empty string when date is before the introduction of the Gregorian Calendar" do
assert Utils.to_masto_date("0621-01-01T00:00:00Z") == ""
end
test "returns empty string when date is BCE" do
assert Utils.to_masto_date("-420-01-01T00:00:00Z") == ""
end
end
describe "maybe_notify_mentioned_recipients/2" do