AkkomaGang/akkoma
AkkomaGang/akkoma
17
68
Fork 110
Code Issues 145 Pull requests 16 Projects 2 Releases 21 Packages Wiki Activity

fix: Give error message to users when address has already been validated #435

Merged
floatingghost merged 1 commit from cheerfulstoic/akkoma:develop into develop 2023-01-15 18:06:13 +00:00
Conversation 1 Commits 1 Files changed 2 +34 -9
cheerfulstoic commented 2023-01-12 21:09:26 +00:00
Contributor
Copy link

Plus other errors.

I noticed this error originally when I signed up on genserver.social and hit the link a second time. I could imagine this might be confusing to somebody if the link opened in the same tab the second time or they just got confused up opening tabs/windows.

It made sense to my to change the 500s to 400s because 400 generally means there was something wrong with the request made and 500 usually means that there was an unexpected / unhandled error. Happy to talk that through, though.

Plus other errors. I noticed this error originally when I signed up on genserver.social and hit the link a second time. I could imagine this might be confusing to somebody if the link opened in the same tab the second time or they just got confused up opening tabs/windows. It made sense to my to change the 500s to 400s because 400 generally means there was something wrong with the request made and 500 usually means that there was an unexpected / unhandled error. Happy to talk that through, though.
fix: Give error message to users when address has already been validated
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details
7ca9ce9d67 
Plus other errors.
floatingghost commented 2023-01-15 18:05:39 +00:00
Owner
Copy link

(lint thing is my fault, apologies)

this looks good, and makes sense

thanks a lot!

(lint thing is my fault, apologies) this looks good, and makes sense thanks a lot!
🎉 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
broken setup

Issue arose from a misconfiguration by the admin, custom patches, manual db edits or similar

  
bug

Something is not working

  
cannot reproduce

   
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs change/feedback

Issue or PR is stalled on response from the author or a third party

  
needs docs

   
needs tests

   
not a bug

   
not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
broken setup
bug
cannot reproduce
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs change/feedback
needs docs
needs tests
not a bug
not our bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AkkomaGang/akkoma!435
No description provided.