AkkomaGang
/
akkoma
9
48
Fork 63
Code Issues 123 Pull Requests 15 Packages Projects 2 Releases 9 Wiki Activity
Labels Milestones

fix invalid proxy_hide_header in example config #472

Merged
floatingghost merged 2 commits from flisk/akkoma:remote-media-docs-fix into develop 3 months ago
Conversation 4 Commits 2 Files Changed 1
flisk commented 3 months ago

proxy_hide_header takes one header per statement in any nginx version i'm aware of, so the current version is probably a typo.

somewhat related: the media proxy config on this page differs a bit from the one in installation/nginx/akkoma.nginx, and it's not really obvious to me which one i should be using. i'm still looking into this, but maybe someone has input on how i could make the docs more consistent?

`proxy_hide_header` takes one header per statement in any nginx version i'm aware of, so the current version is probably a typo. somewhat related: the media proxy config on this page differs a bit from the one in `installation/nginx/akkoma.nginx`, and it's not really obvious to me which one i should be using. i'm still looking into this, but maybe someone has input on how i could make the docs more consistent?
floatingghost commented 3 months ago
Owner

hm curious

maybe there was an old nginx version that allowed this

the media proxy config on this page differs a bit from the one in installation/nginx/akkoma.nginx, and it's not really obvious to me which one i should be using

the one in installation should be correct, so if it could match that it'd be great

hm curious maybe there was an old nginx version that allowed this > the media proxy config on this page differs a bit from the one in installation/nginx/akkoma.nginx, and it's not really obvious to me which one i should be using the one in `installation` should be correct, so if it could match that it'd be great
flisk force-pushed remote-media-docs-fix from 107a72e04c to 3c2fa14634 3 months ago
flisk commented 3 months ago
Poster

how's this?

how's this?
flisk force-pushed remote-media-docs-fix from a5fc20626c to 1ab0b3a0e2 3 months ago
flisk commented 3 months ago
Poster

(little bit of thrashing to make gitea render that link correctly, sorry)

(little bit of thrashing to make gitea render that link correctly, sorry)
floatingghost commented 3 months ago
Owner

that's good, thanks a lot!

that's good, thanks a lot!
floatingghost merged commit c8add9d1dc into develop 3 months ago
floatingghost deleted branch remote-media-docs-fix 3 months ago
The pull request has been merged as c8add9d1dc.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
approved, awaiting change bug
Something is not working configuration
This requires config changes documentation
This is about human-readable docs duplicate
This issue or pull request already exists enhancement
New feature extremely low priority feature request
Something new? Fix it yourself
Support has been attempted help wanted
Need some help invalid
Something is wrong mastodon_api needs docs needs tests not a bug planned pleroma_api privacy question
More information is needed static_fe triage wontfix
This won't be fixed
No Label approved, awaiting change bug configuration documentation duplicate enhancement extremely low priority feature request Fix it yourself help wanted invalid mastodon_api needs docs needs tests not a bug planned pleroma_api privacy question static_fe triage wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#472
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'flisk/akkoma:remote-media-docs-fix'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes