Make UserNote comment default to the empty string. #530

Merged
floatingghost merged 3 commits from provable_ascent/akkoma:provable_ascent-patch-1 into develop 2023-05-22 21:33:02 +00:00
Contributor

This makes the behavior consistent between when UserNote doesn't exist and when comment is null.

The current behavior may return null in APIs, which misleads some clients doing feature detection into thinking the server does not support comments.
For example, see https://codeberg.org/husky/husky/issues/92

This makes the behavior consistent between when UserNote doesn't exist and when comment is null. The current behavior may return null in APIs, which misleads some clients doing feature detection into thinking the server does not support comments. For example, see https://codeberg.org/husky/husky/issues/92
provable_ascent added 1 commit 2023-04-27 05:22:57 +00:00
Make UserNote comment default to the empty string.
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
d8bed0ff63
This make the behavior consistent between when UserNote doesn't exist and when comment is null.

The current behavior may return null in APIs, which misleads some clients doing feature detection into thinking the server does not support comments.
For example, see https://codeberg.org/husky/husky/issues/92

can you add a test to this to confirm that it works as you expect it to? i don't see why it shouldn't but hey

can you add a test to this to confirm that it works as you expect it to? i don't see why it shouldn't but hey
provable_ascent added 1 commit 2023-05-12 02:18:26 +00:00
Add user_note_test.exs.
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
9c4203632d
provable_ascent added 1 commit 2023-05-12 02:19:14 +00:00
Author
Contributor

@floatingghost Test added! PTAL

@floatingghost Test added! PTAL

this is good, thanks a lot!

this is good, thanks a lot!
floatingghost merged commit f72d773cc3 into develop 2023-05-22 21:33:02 +00:00
floatingghost deleted branch provable_ascent-patch-1 2023-05-22 21:33:02 +00:00
Sign in to join this conversation.
No description provided.