AkkomaGang/akkoma
AkkomaGang/akkoma
17
70
Fork 116
Code Issues 147 Pull requests 17 Projects 2 Releases 24 Packages Wiki Activity

Make UserNote comment default to the empty string. #530

Merged
floatingghost merged 3 commits from provable_ascent/akkoma:provable_ascent-patch-1 into develop 2023-05-22 21:33:02 +00:00
Conversation 3 Commits 3 Files changed 2 +1 -1
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d8bed0ff63 - Show all commits

Make UserNote comment default to the empty string.
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details

Prev Next 
This make the behavior consistent between when UserNote doesn't exist and when comment is null.

The current behavior may return null in APIs, which misleads some clients doing feature detection into thinking the server does not support comments.
For example, see https://codeberg.org/husky/husky/issues/92
provable_ascent 2023-04-27 05:22:12 +00:00
commit d8bed0ff63

2
lib/pleroma/user_note.ex
View file

@ -31,7 +31,7 @@ defmodule Pleroma.UserNote do
UserNote
|> where(source_id: ^source.id, target_id: ^target.id)
|> Repo.one() do
note.comment
note.comment || ""
else
_ -> ""
end