AkkomaGang/akkoma
AkkomaGang/akkoma
16
70
Fork 113
Code Issues 150 Pull requests 22 Projects 2 Releases 22 Packages Wiki Activity

Return empty string in the event of no detected language #535

Merged
floatingghost merged 1 commit from midnight/akkoma:fix-libretranslate into develop 2023-05-22 21:30:51 +00:00
Conversation 1 Commits 1 Files changed 2 +19 -3
midnight commented 2023-05-08 23:07:14 +00:00
Contributor
Copy link

This PR guarantees that LibreTranslate will always return a string as the detected string whereas before it could return a nil in the event the server and the request didn't specify a source language.

This conforms to the translator typespec and fixes #369.

This PR guarantees that LibreTranslate will always return a string as the detected string whereas before it could return a nil in the event the server and the request didn't specify a source language. This conforms to the translator typespec and fixes https://akkoma.dev/AkkomaGang/akkoma/issues/369.
Return empty string in the event of no detected language
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
f1e66b39c7
floatingghost commented 2023-05-22 21:30:48 +00:00
Owner
Copy link

this seems ok, thanks!

this seems ok, thanks!
floatingghost deleted branch fix-libretranslate 2023-05-22 21:30:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
broken setup

Issue arose from a misconfiguration by the admin, custom patches, manual db edits or similar

  
bug

Something is not working

  
cannot reproduce

   
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs change/feedback

Issue or PR is stalled on response from the author or a third party

  
needs docs

   
needs tests

   
not a bug

   
not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
broken setup
bug
cannot reproduce
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs change/feedback
needs docs
needs tests
not a bug
not our bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AkkomaGang/akkoma!535
No description provided.