Explicitly allow configDB keys #628
No reviewers
Labels
No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: AkkomaGang/akkoma#628
Loading…
Reference in a new issue
No description provided.
Delete branch "config-db-keys"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Whitelisting settings definitely makes sense to me. I agree with the idea that a sysadmin is not the same as an instance admin, and thus it makes sense to me to keep certain settings away from an instance admin (And I don't see much reason to have sysadmin settings in the db since they should generally not change much or at all).
But now we have configs in
If I understand correctly,
config/description.exs
is used to tell admin-fe what configs can be set. Can't that be used/considered as a whitelist? (Unlessconfig/description.exs
is supposed to become deprecated while moving more settings to akkoma-fe, but I'm unsure if deprecating this is a long term plan.)I do wonder why
db_exclusion_reason
is a thing 🤔 Why add settings there, just to say they are excluded 🤷♀️ Maybe just to make the reasoning clear, idk. Or maybe it does more than I assume it does...@ -0,0 +3,4 @@
# Basically it's silly to let this be configurable
# set a list of things that we can set in the database
# this is mostly our stuff, with some extra in there
The first line of this comment makes sense in the scope of this PR, but not for someone looking at the code as-is. I would remove that line.
I'm not sure what's meant in the last line with "our stuff", so maybe that should also be removed, or clarified?
Pull request closed