AkkomaGang/akkoma
AkkomaGang
/
akkoma
12
63
Fork 83
Code Issues 167 Pull Requests 15 Packages Projects 2 Releases 13 Wiki Activity

Drop base_url special casing in test env #737

Merged
floatingghost merged 1 commits from Oneric/akkoma:testenv_drop_baseurl_specialcase into develop 2024-04-11 18:24:10 +00:00
Conversation 1 Commits 1 Files Changed 4 +33 -33
Oneric commented 2024-04-07 00:13:49 +00:00
Member
Copy Link

61621ebdbc already explicitly added the uploader base url to config/test.exs and it reduces differences from prod.

i prob should’ve done it like this from the start

61621ebdbc5b783fbba7f37559030f7a8e151d53 already explicitly added the uploader base url to config/test.exs and it reduces differences from prod. i prob should’ve done it like this from the start
Oneric added 1 commit 2024-04-07 00:13:49 +00:00
ci/woodpecker/pr/build-amd64 Pipeline is pending Details
ci/woodpecker/pr/build-arm64 Pipeline is pending Details
ci/woodpecker/pr/docs Pipeline is pending Details
ci/woodpecker/pr/lint Pipeline is pending Details
ci/woodpecker/pr/test Pipeline is pending Details
af3ea96a4e Drop base_url special casing in test env 
61621ebdbc already explicitly added
the uploader base url to config/test.exs and it reduces differences
from prod.
Oneric force-pushed testenv_drop_baseurl_specialcase from af3ea96a4e to 9598137d32 2024-04-07 00:20:56 +00:00 Compare
floatingghost commented 2024-04-11 18:24:06 +00:00
Owner
Copy Link

all good, thanks a lot!

all good, thanks a lot!
floatingghost merged commit 0e066bddae into develop 2024-04-11 18:24:10 +00:00
floatingghost deleted branch testenv_drop_baseurl_specialcase 2024-04-11 18:24:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No Label
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#737
No description provided.
Delete Branch "Oneric/akkoma:testenv_drop_baseurl_specialcase"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?