Drop unused indices #767

Merged

floatingghost merged 1 commit from Oneric/akkoma:purge-unused-indices into develop 2024-05-28 01:35:19 +00:00

Conversation 3 Commits 1 Files changed 2 +64 -74

Oneric commented 2024-05-02 00:48:22 +00:00

Owner

Copy link

This promotes and expands our existing optional migration. Based on usage statistics from several instances, see:
#764

activities_hosts is now retained after all since it’s essential for the "instance" query parameter of *oma’s public timeline to reliably work in a reasonable amount of time. (Although akkoma-fe has no support for this feature and apparently barely anyone uses it.)

activities_actor_index was already dropped before in 20221211234352_remove_unused_indices; no need to drop it again.

Birthday indices were introduced in pleroma starting with 20220116183110_add_birthday_to_users which is past the last common migration 20210416051708.

This promotes and expands our existing optional migration. Based on usage statistics from several instances, see: https://akkoma.dev/AkkomaGang/akkoma/issues/764 `activities_hosts` is now retained after all since it’s essential for the "instance" query parameter of *oma’s public timeline to reliably work in a reasonable amount of time. (Although akkoma-fe has no support for this feature and apparently barely anyone uses it.) `activities_actor_index` was already dropped before in 20221211234352_remove_unused_indices; no need to drop it again. Birthday indices were introduced in pleroma starting with `20220116183110_add_birthday_to_users` which is past the last common migration `20210416051708`.

Oneric referenced this pull request 2024-05-02 01:12:59 +00:00

Removing unused indexes #764

Oneric force-pushed purge-unused-indices from 24a34f9d46 to cd50c50c4c 2024-05-03 05:30:27 +00:00 Compare

Oneric force-pushed purge-unused-indices from cd50c50c4c to b7e3d44756 2024-05-03 05:31:30 +00:00 Compare

floatingghost commented 2024-05-06 21:51:00 +00:00

Owner

Copy link

going to run CI tests and compare execution time, and run on IHBA to check any potential performance hit before merging this

going to run CI tests and compare execution time, and run on IHBA to check any potential performance hit before merging this

👍 1

floatingghost commented 2024-05-26 16:25:56 +00:00

Owner

Copy link

applied on ihba without issue, will merge in a few days if nothing goes bad - seems good though

applied on ihba without issue, will merge in a few days if nothing goes bad - seems good though

floatingghost commented 2024-05-28 01:35:14 +00:00

Owner

Copy link

no issues observed in production

no issues observed in production

floatingghost merged commit 72871d4514 into develop 2024-05-28 01:35:19 +00:00

floatingghost deleted branch purge-unused-indices 2024-05-28 01:35:19 +00:00

floatingghost referenced this pull request from a commit 2024-05-28 01:35:20 +00:00

Merge pull request 'Drop unused indices' (#767) from Oneric/akkoma:purge-unused-indices into develop

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

approved, awaiting change

  

bug

Something is not working

  

cannot reproduce

  

configuration

This requires config changes

  

documentation

This is about human-readable docs

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

extremely low priority

  

feature request

Something new?

  

Fix it yourself

Support has been attempted

  

help wanted

Need some help

  

invalid

Something is wrong

  

mastodon_api

  

needs change/feedback

Issue or PR is stalled on response from the author or a third party

  

needs docs

  

needs tests

  

not a bug

  

not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  

planned

  

pleroma_api

  

privacy

  

question

More information is needed

  

static_fe

  

triage

  

wontfix

This won't be fixed

No labels

approved, awaiting change

bug

cannot reproduce

configuration

documentation

duplicate

enhancement

extremely low priority

feature request

Fix it yourself

help wanted

invalid

mastodon_api

needs change/feedback

needs docs

needs tests

not a bug

not our bug

planned

pleroma_api

privacy

question

static_fe

triage

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

AkkomaGang/akkoma!767

No description provided.