AkkomaGang/akkoma
AkkomaGang/akkoma
15
66
Fork 93
Code Issues 176 Pull requests 15 Projects 2 Releases 16 Packages Wiki Activity

Extract keys to their own table, match keyID #816

Merged
floatingghost merged 19 commits from keys-extraction into develop 2024-10-30 15:08:12 +00:00
Conversation 3 Commits 19 Files changed 31 -2
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit c5a44a59db - Show all commits

2
priv/repo/migrations/20240625213637_create_signing_key_table.exs
View file

@ -9,7 +9,5 @@ def change do
add :private_key, :text add :private_key, :text
Oneric commented 2024-07-06 00:33:26 +00:00
Outdated
Review
Copy link

Might :binary be more efficient to not have to reparse the text representation each time we actually verify/sign something? On the other hand, for local users, serving the text representation via AP fetches might be more common than actually using the key...

Might `:binary` be more efficient to not have to reparse the text representation each time we actually verify/sign something? On the other hand, for local users, serving the text representation via AP fetches might be more common than actually using the key...
timestamps() timestamps()
end end
create unique_index(:signing_keys, [:key_id])
end end
end end
floatingghost marked this conversation as resolved Outdated
Oneric commented 2024-07-06 00:10:05 +00:00
Outdated
Review
Copy link

key_id already is the primary key; manually creating an index here just duplicates the already existing unique primary key index

`key_id` already is the primary key; manually creating an index here just duplicates the already existing unique primary key index