Don’t pretend internal actors have follow(er|ing) collections #856

Merged

Oneric merged 2 commits from Oneric/akkoma:fetch-actor-follow-collections into develop 2025-05-09 20:10:42 +00:00

Conversation 10 Commits 2 Files changed 9 +132 -34

Oneric commented 2024-11-23 01:51:47 +00:00

Owner

Copy link

Fixes: #855

Afaict this doesn’t affect anything but internal.fetch since it appears to be the only internal. actor and there’s no nill nickname actor in my DB. In particular the built-in relay actor does not have an internal. prefix and thus should just be a regular user with an unusual AP id (/relay). (Though I’m not using relay functionality)

Fixes: #855 Afaict this doesn’t affect anything but `internal.fetch` since it appears to be the only `internal.` actor and there’s no `nill` nickname actor in my DB. In particular the built-in relay actor does not have an `internal.` prefix and thus should just be a regular user with an unusual AP id (`/relay`). *(Though I’m not using relay functionality)*

Oneric added 2 commits 2024-11-23 01:51:48 +00:00

Don't advertise follow(er|ing) collections for internal actors ... 429575adb5

We don’t actually handle those endpoints just serving the
default frontend’s 404 HTML page, causing other servers to grumble
about it in their logs. Spec explicitly marks these as optional so
just stop pretending we have such collections.
As for real-world interop, Mastodon’s internal instance actor omits
them too, so this is fairly unlikely to cause any issues.

Notably, our built-in relay actor is not affect by this since it has
a non-nil nickname "relay" without "internal." prefix, i.e. it’s just
a regular actor with a funny ActivityPub ID.
In fact, afaict we don't have any "internal." actors
at the moment other than "internal.fetch".

Fixes: #855

cosmetic: adapt software name in internal actor descriptions 778e0ef196

ilja commented 2024-11-28 14:13:33 +00:00

Contributor

Copy link

The relay is also an "Application" actor, and its nickname is NULL in my database (so in code I guess represented as this nickname: nil)

lib/pleroma/web/activity_pub/views/user_view.ex

Line 61 in 778e0ef

def render("user.json", %{user: %User{nickname: nil} = user}),

So at first glance, this may conflict with the relay actor too. It's possible the relay actor is only created when first enabled. For some reason I vaguely remember something like that, but I could be wrong. So maybe that's why you don't see it in your DB.

The relay is also an "Application" actor, and its nickname is NULL in my database (so in code I guess represented as this `nickname: nil`) https://akkoma.dev/AkkomaGang/akkoma/src/commit/778e0ef196689d2450a5b83a7907b58189c5f26e/lib/pleroma/web/activity_pub/views/user_view.ex#L61 So at first glance, this may conflict with the relay actor too. It's possible the relay actor is only created when first enabled. For some reason I vaguely remember something like that, but I could be wrong. So maybe that's why you don't see it in your DB.

Oneric commented 2024-11-28 19:13:21 +00:00

Author

Owner

Copy link

So maybe that's why you don't see it in your DB.

Nope, the thing is i checked this before and it does show up, but behold:

SELECT nickname, ap_id, local
FROM users
WHERE nickname IS NULL OR
      (local = true AND (
        nickname LIKE 'internal%'
        OR invisible = true
      ));

nickname	ap_id	local
internal.fetch	https://<domain>/internal/fetch	t
relay	https://<domain>/relay	t

I guess whether it gets a nickname or not changed at some point; thanks for pointing this out
Do you by chance have any more, legacy NULL nicknames in your DB?

We could limit omission to just internal.*, migrate old relay actors or just keep the omission and check whether we run into any real world problems.

> So maybe that's why you don't see it in your DB. Nope, the thing is i checked this before and it _does_ show up, but behold: ```sql SELECT nickname, ap_id, local FROM users WHERE nickname IS NULL OR (local = true AND ( nickname LIKE 'internal%' OR invisible = true )); ``` nickname | ap_id | local ----------------|-----------------------------------------------------|------- internal.fetch | https://\<domain\>/internal/fetch | t relay | https://\<domain\>/relay | t I guess whether it gets a nickname or not changed at some point; thanks for pointing this out Do you by chance have any more, legacy NULL nicknames in your DB? We could limit omission to just `internal.*`, migrate old `relay` actors or just keep the omission and check whether we run into any real world problems.

ilja commented 2024-11-28 19:44:10 +00:00

Contributor

Copy link

There's a bunch NULL nicknames, but relay is the only local one. internal.fetch and relay are also the only local actors of type "Aplication".

In case it's usefull, here's the database entries

SELECT * FROM users
WHERE actor_type  = 'Application'
and local

id                                  |email|password_hash|name|nickname      |bio|inserted_at            |updated_at             |ap_id                            |avatar|local|follower_address                           |last_refreshed_at|tags|last_digest_emailed_at |following_address|keys      |banner|background|note_count|follower_count|following_count|is_locked|is_confirmed|password_reset_pending|confirmation_token|default_scope|blocks|domain_blocks|mutes|muted_reblogs|muted_notifications|subscribers|is_active|no_rich_text|ap_enabled|is_moderator|is_admin|show_role|uri|hide_followers_count|hide_follows_count|hide_followers|hide_follows|hide_favorites|email_notifications|mascot|emoji|pleroma_settings_store|fields|raw_fields|is_discoverable|invisible|notification_settings                                                                                          |skip_thread_containment|also_known_as|allow_following_move|actor_type |multi_factor_authentication_settings|public_key|inbox|shared_inbox|raw_bio|accepts_chat_messages|is_approved|registration_reason|last_active_at|disclose_client|pinned_objects|featured_address                                      |status_ttl_days|mastofe_settings|is_suggested|last_status_at|language|accepts_direct_messages_from|permit_followback|
------------------------------------+-----+-------------+----+--------------+---+-----------------------+-----------------------+---------------------------------+------+-----+-------------------------------------------+-----------------+----+-----------------------+-----------------+----------+------+----------+----------+--------------+---------------+---------+------------+----------------------+------------------+-------------+------+-------------+-----+-------------+-------------------+-----------+---------+------------+----------+------------+--------+---------+---+--------------------+------------------+--------------+------------+--------------+-------------------+------+-----+----------------------+------+----------+---------------+---------+---------------------------------------------------------------------------------------------------------------+-----------------------+-------------+--------------------+-----------+------------------------------------+----------+-----+------------+-------+---------------------+-----------+-------------------+--------------+---------------+--------------+------------------------------------------------------+---------------+----------------+------------+--------------+--------+----------------------------+-----------------+
00000000-0000-0000-0000-00000000011c|     |             |    |              |   |2018-10-13 15:08:01.520|2024-08-18 16:10:24.000|https://ilja.space/relay         |      |true |https://ilja.space/relay/followers         |                 |{}  |2019-11-11 05:40:25.000|                 |[REDACTED]|      |{}        |         0|            10|              0|false    |true        |false                 |                  |public       |{}    |{}           |{}   |{}           |{}                 |{}         |true     |false       |false     |false       |false   |false    |   |false               |false             |false         |false       |false         |{"digest": false}  |      |{}   |{}                    |[]    |[]        |false          |true     |{"local": true, "remote": true, "follows": true, "followers": true, "non_follows": true, "non_followers": true}|false                  |{}           |true                |Application|{}                                  |          |     |            |       |true                 |true       |                   |              |true           |{}            |https://ilja.space/relay/collections/featured         |               |                |false       |              |        |everybody                   |false            |
0000016e-58c3-eedd-3548-46c141160000|     |             |    |internal.fetch|   |2019-11-11 04:41:06.000|2019-11-11 04:43:05.000|https://ilja.space/internal/fetch|      |true |https://ilja.space/internal/fetch/followers|                 |{}  |2019-11-11 05:41:06.000|                 |[REDACTED]|{}    |{}        |         0|             2|              0|false    |true        |false                 |                  |public       |{}    |{}           |{}   |{}           |{}                 |{}         |true     |false       |false     |false       |false   |true     |   |false               |false             |false         |false       |true          |{"digest": false}  |      |{}   |{}                    |[]    |[]        |false          |true     |{"follows": true, "followers": true, "non_follows": true, "non_followers": true}                               |false                  |{}           |true                |Application|{}                                  |          |     |            |       |true                 |true       |                   |              |true           |{}            |https://ilja.space/internal/fetch/collections/featured|               |                |false       |              |        |everybody                   |false            |

There's a bunch NULL nicknames, but relay is the only local one. internal.fetch and relay are also the only local actors of type "Aplication". <details> <summary>In case it's usefull, here's the database entries</summary> ```sql SELECT * FROM users WHERE actor_type = 'Application' and local ``` ``` id |email|password_hash|name|nickname |bio|inserted_at |updated_at |ap_id |avatar|local|follower_address |last_refreshed_at|tags|last_digest_emailed_at |following_address|keys |banner|background|note_count|follower_count|following_count|is_locked|is_confirmed|password_reset_pending|confirmation_token|default_scope|blocks|domain_blocks|mutes|muted_reblogs|muted_notifications|subscribers|is_active|no_rich_text|ap_enabled|is_moderator|is_admin|show_role|uri|hide_followers_count|hide_follows_count|hide_followers|hide_follows|hide_favorites|email_notifications|mascot|emoji|pleroma_settings_store|fields|raw_fields|is_discoverable|invisible|notification_settings |skip_thread_containment|also_known_as|allow_following_move|actor_type |multi_factor_authentication_settings|public_key|inbox|shared_inbox|raw_bio|accepts_chat_messages|is_approved|registration_reason|last_active_at|disclose_client|pinned_objects|featured_address |status_ttl_days|mastofe_settings|is_suggested|last_status_at|language|accepts_direct_messages_from|permit_followback| ------------------------------------+-----+-------------+----+--------------+---+-----------------------+-----------------------+---------------------------------+------+-----+-------------------------------------------+-----------------+----+-----------------------+-----------------+----------+------+----------+----------+--------------+---------------+---------+------------+----------------------+------------------+-------------+------+-------------+-----+-------------+-------------------+-----------+---------+------------+----------+------------+--------+---------+---+--------------------+------------------+--------------+------------+--------------+-------------------+------+-----+----------------------+------+----------+---------------+---------+---------------------------------------------------------------------------------------------------------------+-----------------------+-------------+--------------------+-----------+------------------------------------+----------+-----+------------+-------+---------------------+-----------+-------------------+--------------+---------------+--------------+------------------------------------------------------+---------------+----------------+------------+--------------+--------+----------------------------+-----------------+ 00000000-0000-0000-0000-00000000011c| | | | | |2018-10-13 15:08:01.520|2024-08-18 16:10:24.000|https://ilja.space/relay | |true |https://ilja.space/relay/followers | |{} |2019-11-11 05:40:25.000| |[REDACTED]| |{} | 0| 10| 0|false |true |false | |public |{} |{} |{} |{} |{} |{} |true |false |false |false |false |false | |false |false |false |false |false |{"digest": false} | |{} |{} |[] |[] |false |true |{"local": true, "remote": true, "follows": true, "followers": true, "non_follows": true, "non_followers": true}|false |{} |true |Application|{} | | | | |true |true | | |true |{} |https://ilja.space/relay/collections/featured | | |false | | |everybody |false | 0000016e-58c3-eedd-3548-46c141160000| | | |internal.fetch| |2019-11-11 04:41:06.000|2019-11-11 04:43:05.000|https://ilja.space/internal/fetch| |true |https://ilja.space/internal/fetch/followers| |{} |2019-11-11 05:41:06.000| |[REDACTED]|{} |{} | 0| 2| 0|false |true |false | |public |{} |{} |{} |{} |{} |{} |true |false |false |false |false |true | |false |false |false |false |true |{"digest": false} | |{} |{} |[] |[] |false |true |{"follows": true, "followers": true, "non_follows": true, "non_followers": true} |false |{} |true |Application|{} | | | | |true |true | | |true |{} |https://ilja.space/internal/fetch/collections/featured| | |false | | |everybody |false | ``` </details>

Oneric commented 2024-11-28 19:52:39 +00:00

Author

Owner

Copy link

Thank you it is helpful and showed yet aother thing: both relay and internal.actor also are marked as actor_type = Person in my database °~°
(internal.fetch still gets exposed as an Application though since its special endpoint doesn't even read the property)

Thank you it is helpful and showed yet aother thing: both `relay` and `internal.actor` also are marked as `actor_type = Person` in my database °~° *(`internal.fetch` still gets exposed as an `Application` though since its special endpoint doesn't even read the property)*

ilja commented 2024-11-28 20:56:08 +00:00

Contributor

Copy link

both relay and internal.actor also are marked as actor_type = Person in my database °~°

huh, that shouldn't be the case since #457

But, yeah, that change apparently didn't really do anything wrt federation for the reason you say. I only realised that today when seeing the code in lib/pleroma/web/activity_pub/views/user_view.ex.

> both `relay` and `internal.actor` also are marked as `actor_type = Person` in my database °~° huh, that shouldn't be the case since https://akkoma.dev/AkkomaGang/akkoma/pulls/457 But, yeah, that change apparently didn't really do anything wrt federation for the reason you say. I only realised that today when seeing the code in *lib/pleroma/web/activity_pub/views/user_view.ex*.

Oneric commented 2024-11-28 23:20:11 +00:00

Author

Owner

Copy link

yeah, that change apparently didn't really do anything wrt federation

it might have done something for relay depending on when its nickname stopped being NULL

huh, that shouldn't be the case since #457

The db was definitely created later than this — but create_service_actor also doesn't set type: "Application" atm.

Querying git log -S reveals: ... PR #457 was accidentally reverted 5 months after it got merged as part of a translation update in eba3cce77b 🥴

> yeah, that change apparently didn't really do anything wrt federation it might have done something for `relay` depending on when its nickname stopped being `NULL` > huh, that shouldn't be the case since #457 The db was definitely created later than this — but `create_service_actor` also doesn't set `type: "Application"` atm. Querying `git log -S` reveals: ... PR #457 was accidentally reverted 5 months after it got merged as part of a translation update in eba3cce77b45e89028f7e6bfa708b469b7416914 🥴

👀 1

Oneric commented 2024-11-29 00:01:45 +00:00

Author

Owner

Copy link

yeah, that change apparently didn't really do anything wrt federation

it might have done something for relay depending on when its nickname stopped being NULL

relay’s nickname stopped being NULL5 years ago in 70410dfafd (subsequently edited again by 7dc275b69b), so your PR last year did affect federation for the relay actor just not internal.fetch

I think it’s best to migrate old installs to a non-NULL nickname for consistency (and at the same time re-add #457). Changing the nickname to internal.relay while conceptually sensible, is prob a bad idea in practice given relay nicknames are already in use and afaik at least Mastodon doesn't allow for nickname changes.
If we do a data migration anyway, we could also stop adding follow collection addresses to internal* actors in the first place (delete for existing dbs) and then use values from the db during render("service.json", user) or omit the fields if NULL. This seems cleanest and allows for future internal actors with follower collections (what relay probably should’ve been) — though then again we didn't get any new internal actors ever, so it’s unlikely to matter

> > yeah, that change apparently didn't really do anything wrt federation > > it might have done something for relay depending on when its nickname stopped being NULL `relay`’s nickname stopped being `NULL`5 years ago in 70410dfafd272bd1f38602446cc4f6e83645326f (subsequently edited again by 7dc275b69bbd50e7a6944c76c5541c0a9c41a051), so your PR last year did affect federation for the `relay` actor just not `internal.fetch` I think it’s best to migrate old installs to a non-NULL nickname for consistency *(and at the same time re-add #457)*. Changing the nickname to `internal.relay` while conceptually sensible, is prob a bad idea in practice given `relay` nicknames are already in use and afaik at least Mastodon doesn't allow for nickname changes. If we do a data migration anyway, we could also stop adding follow collection addresses to `internal*` actors in the first place *(delete for existing dbs)* and then use values from the db during `render("service.json", user)` or omit the fields if `NULL`. This seems cleanest and allows for future internal actors with follower collections *(what `relay` probably should’ve been)* — though then again we didn't get any new internal actors ever, so it’s unlikely to matter

👍 1

ilja commented 2024-11-29 05:56:42 +00:00

Contributor

Copy link

Sounds sensible, yes.

This seems cleanest and allows for future internal actors with follower collections

If a goal is to use "service.json" for these type of Application actors, you could maybe change the checks

  # the instance itself is not a Person, but instead an Application
  def render("user.json", %{user: %User{nickname: nil} = user}),
    do: render("service.json", %{user: user})

  def render("user.json", %{user: %User{nickname: "internal." <> _} = user}),
    do: render("service.json", %{user: user}) |> Map.put("preferredUsername", user.nickname)

to something like

  def render("user.json", %{user: %User{type: "Application"} = user}),
    do: render("service.json", %{user: user})

This makes it more explicit and clearer from the code. It also makes it so that the relay (and possible future Application actors) will use it regardless of nickname.

Sounds sensible, yes. > This seems cleanest and allows for future internal actors with follower collections If a goal is to use "service.json" for these type of Application actors, you could maybe change the checks ``` # the instance itself is not a Person, but instead an Application def render("user.json", %{user: %User{nickname: nil} = user}), do: render("service.json", %{user: user}) def render("user.json", %{user: %User{nickname: "internal." <> _} = user}), do: render("service.json", %{user: user}) |> Map.put("preferredUsername", user.nickname) ``` to something like ``` def render("user.json", %{user: %User{type: "Application"} = user}), do: render("service.json", %{user: user}) ``` This makes it more explicit and clearer from the code. It also makes it so that the relay (and possible future Application actors) will use it regardless of nickname.

Oneric changed title from Don’t pretend internal actors have follow(er|ing) collections to WIP: Don’t pretend internal actors have follow(er|ing) collections 2025-01-03 19:37:56 +00:00

Oneric force-pushed fetch-actor-follow-collections from 778e0ef196 to e342b67e6d 2025-03-26 04:13:24 +00:00 Compare

Oneric changed title from WIP: Don’t pretend internal actors have follow(er|ing) collections to Don’t pretend internal actors have follow(er|ing) collections 2025-03-26 04:14:10 +00:00

Oneric commented 2025-03-26 04:14:58 +00:00

Author

Owner

Copy link

Implemented the discussed changes; it’d be great if you could confirm this works as intended on your old instance @ilja

Implemented the discussed changes; it’d be great if you could confirm this works as intended on your old instance @ilja

❤️ 1

Oneric force-pushed fetch-actor-follow-collections from e342b67e6d to 9f51f67fda 2025-03-26 04:16:32 +00:00 Compare

Oneric force-pushed fetch-actor-follow-collections from 9f51f67fda to 523c59fede 2025-03-26 16:13:29 +00:00 Compare

Oneric force-pushed fetch-actor-follow-collections from 523c59fede to caf6b4606f 2025-03-26 16:14:34 +00:00 Compare

ilja commented 2025-04-06 07:07:46 +00:00

Contributor

Copy link

I switched to develop, then merged 'oneric/fetch-actor-follow-collections'.

Before the switch:

curl 'https://ilja.space/relay' -H 'Accept: application/activity+json' | jq .

{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://ilja.space/schemas/litepub-0.1.jsonld",
    {
      "@language": "und"
    }
  ],
  "endpoints": {
    "sharedInbox": "https://ilja.space/inbox"
  },
  "followers": "https://ilja.space/relay/followers",
  "following": "https://ilja.space/relay/following",
  "id": "https://ilja.space/relay",
  "inbox": "https://ilja.space/relay/inbox",
  "invisible": true,
  "manuallyApprovesFollowers": false,
  "name": "Pleroma",
  "outbox": "https://ilja.space/relay/outbox",
  "publicKey": {
    "id": "https://ilja.space/relay#main-key",
    "owner": "https://ilja.space/relay",
    "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA6aZ5ufOQ5PmilVWq4Ou/\nO9ien63HSBMhoeXaECpJHFm197B/brctoRtyrGGUNZ+/sAfsLsIGBYtvDz8V319c\nFthHEKby5TvnpvY3ClHLyb40ZKox/HPf370JGOUdij04U8dNWOKruRY/3Zv+ZBwv\nsaTWNcrkiWd5K/1pT6tXkz/TUTdZer6V3Ac1qbxmLY+e3cleDAwTS9wOTsabe9Yb\nbanK+RsI2bC5cqUINYOOLk7mcjMgcgCIU8cEviHvvxcrNhpOnI3Vxeo2LevSaLoQ\nKSmjR+foWLGgNmqn3Dwj4A5lmJqTASLq1piFOxjOSk5e1bib2u6FkEccBkldOL9s\nZwIDAQAB\n-----END PUBLIC KEY-----\n\n"
  },
  "summary": "An internal service actor for this Pleroma instance.  No user-serviceable parts inside.",
  "type": "Application",
  "url": "https://ilja.space/relay"
}

curl 'https://ilja.space/internal/fetch' -H 'Accept: application/activity+json' | jq .

{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://ilja.space/schemas/litepub-0.1.jsonld",
    {
      "@language": "und"
    }
  ],
  "endpoints": {
    "oauthAuthorizationEndpoint": "https://ilja.space/oauth/authorize",
    "oauthRegistrationEndpoint": "https://ilja.space/api/v1/apps",
    "oauthTokenEndpoint": "https://ilja.space/oauth/token",
    "sharedInbox": "https://ilja.space/inbox"
  },
  "followers": "https://ilja.space/internal/fetch/followers",
  "following": "https://ilja.space/internal/fetch/following",
  "id": "https://ilja.space/internal/fetch",
  "inbox": "https://ilja.space/internal/fetch/inbox",
  "invisible": true,
  "manuallyApprovesFollowers": false,
  "name": "Pleroma",
  "outbox": "https://ilja.space/internal/fetch/outbox",
  "preferredUsername": "internal.fetch",
  "publicKey": {
    "id": "https://ilja.space/internal/fetch#main-key",
    "owner": "https://ilja.space/internal/fetch",
    "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAvweL1bsEh91QR3L3BKce\nJ/0Pl7x/ze09txVIor6U9v97RMOwwE/JofCVbwQDsXqv1vUmsNAKAvaqoqY5uYcl\nWuvN6mqKHI9JkoJPYTvDSP8p9plgL61HtIHeb6EOBSK02CVEGAn1V7xv4BH07VrK\ndV8xyx7fGaO+O/V9Rdw0Y1/q/12San3ayt/wal2R/4qcEd8Na8sUo82Pdw3eyCvm\nHKlpeX/T331KsWJKZ326cnb3fZZHP9pEv7x37IvlpsUVu0S2TOgqs9atzPHZKWEb\nF44sLrgFmb9rW/hhalLJuSL9+cjhWNGhreB0S242wpwiFbfhfBdoGcAcyvvbWBsm\n+wIDAQAB\n-----END PUBLIC KEY-----\n\n"
  },
  "summary": "An internal service actor for this Pleroma instance.  No user-serviceable parts inside.",
  "type": "Application",
  "url": "https://ilja.space/internal/fetch"
}

After the switch:

curl 'https://ilja.space/relay' -H 'Accept: application/activity+json' | jq .

{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://ilja.space/schemas/litepub-0.1.jsonld",
    {
      "@language": "und"
    }
  ],
  "endpoints": {
    "oauthAuthorizationEndpoint": "https://ilja.space/oauth/authorize",
    "oauthRegistrationEndpoint": "https://ilja.space/api/v1/apps",
    "oauthTokenEndpoint": "https://ilja.space/oauth/token",
    "sharedInbox": "https://ilja.space/inbox"
  },
  "followers": "https://ilja.space/relay/followers",
  "following": "https://ilja.space/relay/following",
  "id": "https://ilja.space/relay",
  "inbox": "https://ilja.space/relay/inbox",
  "invisible": true,
  "manuallyApprovesFollowers": false,
  "name": "Akkoma",
  "outbox": "https://ilja.space/relay/outbox",
  "publicKey": {
    "id": "https://ilja.space/relay#main-key",
    "owner": "https://ilja.space/relay",
    "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA6aZ5ufOQ5PmilVWq4Ou/\nO9ien63HSBMhoeXaECpJHFm197B/brctoRtyrGGUNZ+/sAfsLsIGBYtvDz8V319c\nFthHEKby5TvnpvY3ClHLyb40ZKox/HPf370JGOUdij04U8dNWOKruRY/3Zv+ZBwv\nsaTWNcrkiWd5K/1pT6tXkz/TUTdZer6V3Ac1qbxmLY+e3cleDAwTS9wOTsabe9Yb\nbanK+RsI2bC5cqUINYOOLk7mcjMgcgCIU8cEviHvvxcrNhpOnI3Vxeo2LevSaLoQ\nKSmjR+foWLGgNmqn3Dwj4A5lmJqTASLq1piFOxjOSk5e1bib2u6FkEccBkldOL9s\nZwIDAQAB\n-----END PUBLIC KEY-----\n\n"
  },
  "summary": "An internal service actor for this Akkoma instance.  No user-serviceable parts inside.",
  "type": "Application",
  "url": "https://ilja.space/relay"
}

curl 'https://ilja.space/internal/fetch' -H 'Accept: application/activity+json' | jq .

{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://ilja.space/schemas/litepub-0.1.jsonld",
    {
      "@language": "und"
    }
  ],
  "endpoints": {
    "oauthAuthorizationEndpoint": "https://ilja.space/oauth/authorize",
    "oauthRegistrationEndpoint": "https://ilja.space/api/v1/apps",
    "oauthTokenEndpoint": "https://ilja.space/oauth/token",
    "sharedInbox": "https://ilja.space/inbox"
  },
  "id": "https://ilja.space/internal/fetch",
  "inbox": "https://ilja.space/internal/fetch/inbox",
  "invisible": true,
  "manuallyApprovesFollowers": false,
  "name": "Akkoma",
  "outbox": "https://ilja.space/internal/fetch/outbox",
  "preferredUsername": "internal.fetch",
  "publicKey": {
    "id": "https://ilja.space/internal/fetch#main-key",
    "owner": "https://ilja.space/internal/fetch",
    "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAvweL1bsEh91QR3L3BKce\nJ/0Pl7x/ze09txVIor6U9v97RMOwwE/JofCVbwQDsXqv1vUmsNAKAvaqoqY5uYcl\nWuvN6mqKHI9JkoJPYTvDSP8p9plgL61HtIHeb6EOBSK02CVEGAn1V7xv4BH07VrK\ndV8xyx7fGaO+O/V9Rdw0Y1/q/12San3ayt/wal2R/4qcEd8Na8sUo82Pdw3eyCvm\nHKlpeX/T331KsWJKZ326cnb3fZZHP9pEv7x37IvlpsUVu0S2TOgqs9atzPHZKWEb\nF44sLrgFmb9rW/hhalLJuSL9+cjhWNGhreB0S242wpwiFbfhfBdoGcAcyvvbWBsm\n+wIDAQAB\n-----END PUBLIC KEY-----\n\n"
  },
  "summary": "An internal service actor for this Akkoma instance.  No user-serviceable parts inside.",
  "type": "Application",
  "url": "https://ilja.space/internal/fetch"
}

This shows that the followers and following collection is gone from internal.fetch, but not from relay. When I check my database, I see that internal.fetch has NULL for both addresses, while for relay they are both filled in. If I understand correctly, this was the goal, so yeay! I'll run for a while. I don't think I'll notice if the relay breaks (it's on, but I don't personally use it for anything myself and I'm unsure if anyone really does), but at least internal.fetch should be noticeable if I get federation problems.

I switched to develop, then merged 'oneric/fetch-actor-follow-collections'. Before the switch: <details> <summary> ```sh curl 'https://ilja.space/relay' -H 'Accept: application/activity+json' | jq . ``` </summary> ```json { "@context": [ "https://www.w3.org/ns/activitystreams", "https://ilja.space/schemas/litepub-0.1.jsonld", { "@language": "und" } ], "endpoints": { "sharedInbox": "https://ilja.space/inbox" }, "followers": "https://ilja.space/relay/followers", "following": "https://ilja.space/relay/following", "id": "https://ilja.space/relay", "inbox": "https://ilja.space/relay/inbox", "invisible": true, "manuallyApprovesFollowers": false, "name": "Pleroma", "outbox": "https://ilja.space/relay/outbox", "publicKey": { "id": "https://ilja.space/relay#main-key", "owner": "https://ilja.space/relay", "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA6aZ5ufOQ5PmilVWq4Ou/\nO9ien63HSBMhoeXaECpJHFm197B/brctoRtyrGGUNZ+/sAfsLsIGBYtvDz8V319c\nFthHEKby5TvnpvY3ClHLyb40ZKox/HPf370JGOUdij04U8dNWOKruRY/3Zv+ZBwv\nsaTWNcrkiWd5K/1pT6tXkz/TUTdZer6V3Ac1qbxmLY+e3cleDAwTS9wOTsabe9Yb\nbanK+RsI2bC5cqUINYOOLk7mcjMgcgCIU8cEviHvvxcrNhpOnI3Vxeo2LevSaLoQ\nKSmjR+foWLGgNmqn3Dwj4A5lmJqTASLq1piFOxjOSk5e1bib2u6FkEccBkldOL9s\nZwIDAQAB\n-----END PUBLIC KEY-----\n\n" }, "summary": "An internal service actor for this Pleroma instance. No user-serviceable parts inside.", "type": "Application", "url": "https://ilja.space/relay" } ``` </details> <details> <summary> ```sh curl 'https://ilja.space/internal/fetch' -H 'Accept: application/activity+json' | jq . ``` </summary> ```json { "@context": [ "https://www.w3.org/ns/activitystreams", "https://ilja.space/schemas/litepub-0.1.jsonld", { "@language": "und" } ], "endpoints": { "oauthAuthorizationEndpoint": "https://ilja.space/oauth/authorize", "oauthRegistrationEndpoint": "https://ilja.space/api/v1/apps", "oauthTokenEndpoint": "https://ilja.space/oauth/token", "sharedInbox": "https://ilja.space/inbox" }, "followers": "https://ilja.space/internal/fetch/followers", "following": "https://ilja.space/internal/fetch/following", "id": "https://ilja.space/internal/fetch", "inbox": "https://ilja.space/internal/fetch/inbox", "invisible": true, "manuallyApprovesFollowers": false, "name": "Pleroma", "outbox": "https://ilja.space/internal/fetch/outbox", "preferredUsername": "internal.fetch", "publicKey": { "id": "https://ilja.space/internal/fetch#main-key", "owner": "https://ilja.space/internal/fetch", "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAvweL1bsEh91QR3L3BKce\nJ/0Pl7x/ze09txVIor6U9v97RMOwwE/JofCVbwQDsXqv1vUmsNAKAvaqoqY5uYcl\nWuvN6mqKHI9JkoJPYTvDSP8p9plgL61HtIHeb6EOBSK02CVEGAn1V7xv4BH07VrK\ndV8xyx7fGaO+O/V9Rdw0Y1/q/12San3ayt/wal2R/4qcEd8Na8sUo82Pdw3eyCvm\nHKlpeX/T331KsWJKZ326cnb3fZZHP9pEv7x37IvlpsUVu0S2TOgqs9atzPHZKWEb\nF44sLrgFmb9rW/hhalLJuSL9+cjhWNGhreB0S242wpwiFbfhfBdoGcAcyvvbWBsm\n+wIDAQAB\n-----END PUBLIC KEY-----\n\n" }, "summary": "An internal service actor for this Pleroma instance. No user-serviceable parts inside.", "type": "Application", "url": "https://ilja.space/internal/fetch" } ``` </details> After the switch: <details> <summary> ```sh curl 'https://ilja.space/relay' -H 'Accept: application/activity+json' | jq . ``` </summary> ```json { "@context": [ "https://www.w3.org/ns/activitystreams", "https://ilja.space/schemas/litepub-0.1.jsonld", { "@language": "und" } ], "endpoints": { "oauthAuthorizationEndpoint": "https://ilja.space/oauth/authorize", "oauthRegistrationEndpoint": "https://ilja.space/api/v1/apps", "oauthTokenEndpoint": "https://ilja.space/oauth/token", "sharedInbox": "https://ilja.space/inbox" }, "followers": "https://ilja.space/relay/followers", "following": "https://ilja.space/relay/following", "id": "https://ilja.space/relay", "inbox": "https://ilja.space/relay/inbox", "invisible": true, "manuallyApprovesFollowers": false, "name": "Akkoma", "outbox": "https://ilja.space/relay/outbox", "publicKey": { "id": "https://ilja.space/relay#main-key", "owner": "https://ilja.space/relay", "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA6aZ5ufOQ5PmilVWq4Ou/\nO9ien63HSBMhoeXaECpJHFm197B/brctoRtyrGGUNZ+/sAfsLsIGBYtvDz8V319c\nFthHEKby5TvnpvY3ClHLyb40ZKox/HPf370JGOUdij04U8dNWOKruRY/3Zv+ZBwv\nsaTWNcrkiWd5K/1pT6tXkz/TUTdZer6V3Ac1qbxmLY+e3cleDAwTS9wOTsabe9Yb\nbanK+RsI2bC5cqUINYOOLk7mcjMgcgCIU8cEviHvvxcrNhpOnI3Vxeo2LevSaLoQ\nKSmjR+foWLGgNmqn3Dwj4A5lmJqTASLq1piFOxjOSk5e1bib2u6FkEccBkldOL9s\nZwIDAQAB\n-----END PUBLIC KEY-----\n\n" }, "summary": "An internal service actor for this Akkoma instance. No user-serviceable parts inside.", "type": "Application", "url": "https://ilja.space/relay" } ``` </details> <details> <summary> ```sh curl 'https://ilja.space/internal/fetch' -H 'Accept: application/activity+json' | jq . ``` </summary> ```json { "@context": [ "https://www.w3.org/ns/activitystreams", "https://ilja.space/schemas/litepub-0.1.jsonld", { "@language": "und" } ], "endpoints": { "oauthAuthorizationEndpoint": "https://ilja.space/oauth/authorize", "oauthRegistrationEndpoint": "https://ilja.space/api/v1/apps", "oauthTokenEndpoint": "https://ilja.space/oauth/token", "sharedInbox": "https://ilja.space/inbox" }, "id": "https://ilja.space/internal/fetch", "inbox": "https://ilja.space/internal/fetch/inbox", "invisible": true, "manuallyApprovesFollowers": false, "name": "Akkoma", "outbox": "https://ilja.space/internal/fetch/outbox", "preferredUsername": "internal.fetch", "publicKey": { "id": "https://ilja.space/internal/fetch#main-key", "owner": "https://ilja.space/internal/fetch", "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAvweL1bsEh91QR3L3BKce\nJ/0Pl7x/ze09txVIor6U9v97RMOwwE/JofCVbwQDsXqv1vUmsNAKAvaqoqY5uYcl\nWuvN6mqKHI9JkoJPYTvDSP8p9plgL61HtIHeb6EOBSK02CVEGAn1V7xv4BH07VrK\ndV8xyx7fGaO+O/V9Rdw0Y1/q/12San3ayt/wal2R/4qcEd8Na8sUo82Pdw3eyCvm\nHKlpeX/T331KsWJKZ326cnb3fZZHP9pEv7x37IvlpsUVu0S2TOgqs9atzPHZKWEb\nF44sLrgFmb9rW/hhalLJuSL9+cjhWNGhreB0S242wpwiFbfhfBdoGcAcyvvbWBsm\n+wIDAQAB\n-----END PUBLIC KEY-----\n\n" }, "summary": "An internal service actor for this Akkoma instance. No user-serviceable parts inside.", "type": "Application", "url": "https://ilja.space/internal/fetch" } ``` </details> This shows that the followers and following collection is gone from `internal.fetch`, but not from `relay`. When I check my database, I see that `internal.fetch` has NULL for both addresses, while for `relay` they are both filled in. If I understand correctly, this was the goal, so yeay! I'll run for a while. I don't think I'll notice if the relay breaks (it's on, but I don't personally use it for anything myself and I'm unsure if anyone really does), but at least internal.fetch should be noticeable if I get federation problems.

❤️ 1

Oneric merged commit aac5493dd5 into develop 2025-05-09 20:10:41 +00:00

Oneric referenced this pull request from a commit 2025-05-09 20:10:43 +00:00

Merge pull request 'Don’t pretend internal actors have follow(er|ing) collections' (#856) from Oneric/akkoma:fetch-actor-follow-collections into develop

Oneric deleted branch fetch-actor-follow-collections 2025-05-09 20:10:48 +00:00

Oneric referenced this pull request 2025-08-18 12:09:41 +00:00

[bug] problem with relay and akkoma #416

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

approved, awaiting change

  

bug

Something is not working

  

cannot reproduce

  

configuration

This requires config changes

  

documentation

This is about human-readable docs

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

extremely low priority

  

feature request

Something new?

  

Fix it yourself

Support has been attempted

  

help wanted

Need some help

  

invalid

Something is wrong

  

mastodon_api

  

needs change/feedback

Issue or PR is stalled on response from the author or a third party

  

needs docs

  

needs tests

  

not a bug

  

not our bug

Bug in a dependency of ours (meaning we can't just fix it), or in another AP implementation or client interfacing with Akkoma (which needs to be fixed on their end)

  

planned

  

pleroma_api

  

privacy

  

question

More information is needed

  

static_fe

  

triage

  

wontfix

This won't be fixed

No labels

approved, awaiting change

bug

cannot reproduce

configuration

documentation

duplicate

enhancement

extremely low priority

feature request

Fix it yourself

help wanted

invalid

mastodon_api

needs change/feedback

needs docs

needs tests

not a bug

not our bug

planned

pleroma_api

privacy

question

static_fe

triage

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

AkkomaGang/akkoma!856

No description provided.