Only proxy HTTP and HTTP urls via Media Proxy #860
No reviewers
Labels
No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: AkkomaGang/akkoma#860
Loading…
Reference in a new issue
No description provided.
Delete branch "nopjmp/akkoma:media-proxy-only-http"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
We make an assumption that we are only proxying HTTP/HTTPS hosted
media through the media proxy endpoint.
Fixes: #859
The only test I had issues with was "redirects to media proxy URI in case of thumbnailing error" due to having installed html2ps and it was added as a delegate to ImageMagick allowed for the error to be converted into an image. I uninstalled html2ps and everything passed.
We probably don't want to convert html into any images, so if we don't want that I can look at making another PR to see about removing extra ImageMagick functionality.
Oh right, you’ve mentioned using elixir 1.14, but the style guide slightly changed with 1.15 or 1.16; sorry i forgot about that. Current
develop
is alreadymix format
clean with current elixir. Apart from the first commit, i can confirm this patch ismix format
clean too, so just drop the first one and everything should be fine; thanks!8ea721a5f2
toff5d197341
fixed, it was unclear what Elixir version I should be using. I'm not super familiar with Elixir so I wasn't aware formatting defaults changed between versions.
it surprised me too when it happened `^^