AkkomaGang/akkoma
AkkomaGang/akkoma
15
67
Fork 100
Code Issues 181 Pull requests 28 Projects 2 Releases 19 Packages Wiki Activity

Add oban web dashboard #871

Merged
floatingghost merged 5 commits from oban_web into develop 2025-02-27 12:07:37 +00:00
Conversation 0 Commits 5 Files changed 9 +106 -50
floatingghost commented 2025-02-21 15:26:16 +00:00
Owner
Copy link

been running on ihba for some time with no issue

looks like this

image

been running on ihba for some time with no issue looks like this ![image](/attachments/b0297c1a-b4f1-43fc-80a0-7a30f330d7b8)
image.png
96 KiB
floatingghost added 1 commit 2025-02-21 15:26:16 +00:00
add oban web
Some checks failed
ci/woodpecker/push/lint Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/push/build-amd64 Pipeline was successful
Details
ci/woodpecker/push/build-arm64 Pipeline was successful
Details
ci/woodpecker/push/docs Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline failed
Details
ci/woodpecker/pr/test unknown status
Details
ci/woodpecker/pr/build-amd64 unknown status
Details
ci/woodpecker/pr/build-arm64 unknown status
Details
ci/woodpecker/pr/docs unknown status
Details
b2b63ad89f
Oneric reviewed 2025-02-21 19:14:38 +00:00
lib/pleroma/web/router.ex Outdated
@ -904,2 +905,4 @@
csp_nonce_assign_key: :csp_nonce
)
oban_dashboard("/oban/dashboard", csp_nonce_assign_key: :csp_nonce)
Oneric commented 2025-02-21 19:14:38 +00:00
Member
Copy link

This will make oban and API prefix and may introduce regressions similar to what happened in de64c6c54a (fixed in a3101a435b).
It would be best to use an existing API prefix here, e.g. /akkoma/oban_dashboard or /web/oban/dashboard. All current API prefixes listed below (obtained by running Pleroma.Web.Router.get_api_routes()):

["api", "main", "ostatus_subscribe", "oauth", "akkoma", "objects", "activities",
 "notice", "@:nickname", ":nickname", "users", "tags", "mailer", "inbox",
 "relay", "internal", ".well-known", "nodeinfo", "manifest.json", "web", "auth",
 "embed", "proxy", "phoenix", "user_exists", "check_password"]

It might be a good idea to add a test ensuring no new API prefixes are added by accident going forward

This will make `oban` and API prefix and may introduce regressions similar to what happened in de64c6c54aaacc4123031f2e3d5bfb9fc9c517fe (fixed in a3101a435bae8bba7da77bba52d80e06b85593a4). It would be best to use an existing API prefix here, e.g. `/akkoma/oban_dashboard` or `/web/oban/dashboard`. All current API prefixes listed below *(obtained by running `Pleroma.Web.Router.get_api_routes()`)*: ``` ["api", "main", "ostatus_subscribe", "oauth", "akkoma", "objects", "activities", "notice", "@:nickname", ":nickname", "users", "tags", "mailer", "inbox", "relay", "internal", ".well-known", "nodeinfo", "manifest.json", "web", "auth", "embed", "proxy", "phoenix", "user_exists", "check_password"] ``` It might be a good idea to add a test ensuring no new API prefixes are added by accident going forward
floatingghost commented 2025-02-23 16:52:46 +00:00
Author
Owner
Copy link

i've added a snapshot test for this to make sure we don't run into it again

i've added a snapshot test for this to make sure we don't run into it again
👍 1
floatingghost added 3 commits 2025-02-23 16:33:01 +00:00
update deps
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending approval
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending approval
Details
ci/woodpecker/pr/docs Pipeline is pending approval
Details
ci/woodpecker/pr/lint Pipeline is pending approval
Details
ci/woodpecker/pr/test Pipeline is pending approval
Details
ci/woodpecker/push/lint Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/push/build-arm64 Pipeline was successful
Details
ci/woodpecker/push/build-amd64 Pipeline was successful
Details
ci/woodpecker/push/docs Pipeline was successful
Details
13d650602b
floatingghost added 1 commit 2025-02-23 16:52:06 +00:00
add a snapshot test for api prefixes
Some checks are pending
ci/woodpecker/push/lint Pipeline was successful
Details
ci/woodpecker/push/build-arm64 Pipeline is running
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/push/build-amd64 Pipeline was successful
Details
ci/woodpecker/push/docs Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/build-arm64 Pipeline was successful
Details
ci/woodpecker/pr/build-amd64 Pipeline was successful
Details
ci/woodpecker/pr/docs Pipeline was successful
Details
ci/woodpecker/pull_request_closed/lint Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-amd64 Pipeline was successful
Details
ci/woodpecker/pull_request_closed/docs Pipeline was successful
Details
ci/woodpecker/pull_request_closed/test Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-arm64 Pipeline was successful
Details
c2f60c9228
Oneric reviewed 2025-02-26 01:39:09 +00:00
.formatter.exs
@ -1,6 +1,5 @@
[
import_deps: [:ecto, :ecto_sql, :phoenix],
subdirectories: ["priv/*/migrations"],
Oneric commented 2025-02-26 01:39:09 +00:00
Member
Copy link

Were migrations intentionally excluded from formatting?

Were migrations intentionally excluded from formatting?
floatingghost commented 2025-02-26 02:13:46 +00:00
Author
Owner
Copy link

so fun fact the subdirectories thing

per docs:

subdirectories (a list of paths and patterns) - specifies subdirectories that have their own formatting rules. Each subdirectory should have a .formatter.exs that configures how entries in that subdirectory should be formatted as.

which migrations... don't

I'm not sure why this setting was here at all

so fun fact the subdirectories thing per docs: >subdirectories (a list of paths and patterns) - specifies subdirectories that have their own formatting rules. Each subdirectory should have a .formatter.exs that configures how entries in that subdirectory should be formatted as. which migrations... don't I'm not sure why this setting was here at all
Oneric commented 2025-02-26 18:12:06 +00:00
Member
Copy link

huh, yeah all good to purge then (i can't mark the threads here as resolved)

huh, yeah all good to purge then *(i can't mark the threads here as resolved)*
floatingghost merged commit d65cd1b141 into develop 2025-02-27 12:07:37 +00:00
floatingghost deleted branch oban_web 2025-02-27 12:07:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#871
No description provided.
Delete branch "oban_web"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?