mediaproxy: proxy network-path references #903

Merged

Oneric merged 1 commit from Oneric/akkoma:mediaproxy_networkpathref into develop

2025-05-09 20:13:56 +00:00

Oneric commented

2025-04-17 23:51:38 +00:00

Owner

Discovered-by: snow
Fixes: #900

Since I’m not using media proxy, this is only tested in dev, not in real-world prod.
While regressions seem unlikely, more testing is welcome.

Additionally it turns out inlined images are treated separately from other proxy logic and hard replaced on post creation or receipt. Meaning the proxied form of the URL is saved to the database and things will break if the base url changes or media proxy is disabled later.
However that’s a separate concern from omitting network-path references and can be handled another time, preferably by someone actually using media proxy in prod.

Update: Patches got tested by nopjmp

Discovered-by: snow Fixes: https://akkoma.dev/AkkomaGang/akkoma/issues/900 --- Since I’m not using media proxy, this is only tested in dev, not in real-world prod. While regressions seem unlikely, more testing is welcome. --- Additionally it turns out inlined images are treated separately from other proxy logic and hard replaced on post creation or receipt. Meaning the proxied form of the URL is saved to the database and things will break if the base url changes or media proxy is disabled later. However that’s a separate concern from omitting network-path references and can be handled another time, preferably by someone actually using media proxy in prod. *Update:* Patches got [tested by nopjmp](https://akkoma.dev/AkkomaGang/akkoma/pulls/860#issuecomment-14015)

Oneric added 1 commit 2025-04-17 23:51:38 +00:00