mediaproxy: proxy network-path references #903

Merged
Oneric merged 1 commit from Oneric/akkoma:mediaproxy_networkpathref into develop 2025-05-09 20:13:56 +00:00
Owner

Discovered-by: snow
Fixes: #900


Since I’m not using media proxy, this is only tested in dev, not in real-world prod.
While regressions seem unlikely, more testing is welcome.


Additionally it turns out inlined images are treated separately from other proxy logic and hard replaced on post creation or receipt. Meaning the proxied form of the URL is saved to the database and things will break if the base url changes or media proxy is disabled later.
However that’s a separate concern from omitting network-path references and can be handled another time, preferably by someone actually using media proxy in prod.

Update: Patches got tested by nopjmp

Discovered-by: snow Fixes: https://akkoma.dev/AkkomaGang/akkoma/issues/900 --- Since I’m not using media proxy, this is only tested in dev, not in real-world prod. While regressions seem unlikely, more testing is welcome. --- Additionally it turns out inlined images are treated separately from other proxy logic and hard replaced on post creation or receipt. Meaning the proxied form of the URL is saved to the database and things will break if the base url changes or media proxy is disabled later. However that’s a separate concern from omitting network-path references and can be handled another time, preferably by someone actually using media proxy in prod. *Update:* Patches got [tested by nopjmp](https://akkoma.dev/AkkomaGang/akkoma/pulls/860#issuecomment-14015)
Oneric added 1 commit 2025-04-17 23:51:38 +00:00
mediaproxy: proxy network-path references
Some checks failed
ci/woodpecker/pr/build-amd64 Pipeline is pending
ci/woodpecker/pr/lint Pipeline was successful
ci/woodpecker/pr/test/2 Pipeline was successful
ci/woodpecker/pr/test/1 Pipeline was successful
ci/woodpecker/pr/build-arm64 Pipeline was successful
ci/woodpecker/pull_request_closed/lint Pipeline is pending
ci/woodpecker/pull_request_closed/test/1 Pipeline is pending
ci/woodpecker/pull_request_closed/test/2 Pipeline is pending
ci/woodpecker/pull_request_closed/build-arm64 unknown status
ci/woodpecker/pr/docs unknown status
ci/woodpecker/pull_request_closed/build-amd64 unknown status
ci/woodpecker/pull_request_closed/docs unknown status
bbf974adc8
Discovered-by: snow
Fixes: #900
Oneric merged commit c3d163d34d into develop 2025-05-09 20:13:56 +00:00
Oneric deleted branch mediaproxy_networkpathref 2025-05-09 20:13:56 +00:00
Sign in to join this conversation.
No description provided.