api/masto/instance: use WebFinger domain for URI #927

Merged

Oneric merged 1 commit from Oneric/akkoma:mastoapi_instance-uri into develop 2025-05-15 19:45:09 +00:00

Conversation 0 Commits 1 Files changed 2 +14 -2

Oneric commented 2025-05-15 19:10:58 +00:00

Owner

Copy link

Despite its name this property is not supposed to be a full URI,
but just a bare domain witout protocol. Furthermore, it’s supposed
to be the WebFinger domain used in userhandles and NOT the domain used
for API and ActivityPub objects (which every caller will already know
anyway).

Not following this caused issues for Pachli and Tusky.

Reported-by: nikclayton

Despite its name this property is not supposed to be a full URI, but just a bare domain witout protocol. Furthermore, it’s supposed to be the WebFinger domain used in userhandles and NOT the domain used for API and ActivityPub objects (which every caller will already know anyway). Not following this caused issues for Pachli and Tusky. Reported-by: nikclayton

Oneric added 1 commit 2025-05-15 19:10:58 +00:00

api/masto/instance: use WebFinger domain for URI ... 40fef8e632

Despite its name this property is not supposed to be a full URI,
but just a bare domain witout protocol. Furthermore, it’s supposed
to be the WebFinger domain used in userhandles and NOT the domain used
for API and ActivityPub objects (which every caller will already know
anyway).

Not following this caused issues for Pachli and Tusky.

Reported-by: nikclayton

Oneric referenced this pull request 2025-05-15 19:12:27 +00:00

fix: Return the webfinger host as the instancev1 uri property #908

Oneric merged commit 771d3c3103 into develop 2025-05-15 19:45:09 +00:00

Oneric deleted branch mastoapi_instance-uri 2025-05-15 19:45:09 +00:00

Oneric referenced this pull request from a commit 2025-05-15 19:45:09 +00:00

Merge pull request 'api/masto/instance: use WebFinger domain for URI' (#927) from Oneric/akkoma:mastoapi_instance-uri into develop

Oneric referenced this pull request 2025-05-16 09:40:15 +00:00

[bug] /api/v1/instance, uri property is a URI, instead of a bare domain #907

z411 referenced this pull request 2025-05-27 23:28:31 +00:00

Use WebFinger domain for user's fqn #936

Oneric referenced this pull request 2025-05-28 16:01:25 +00:00

Use WebFinger domain for user's fqn #936

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

approved, awaiting change

  

bug

Something is not working

  

configuration

This requires config changes

  

documentation

This is about human-readable docs

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

extremely low priority

  

feature request

Something new?

  

Fix it yourself

Support has been attempted

  

help wanted

Need some help

  

invalid

Something is wrong

  

mastodon_api

  

needs change/feedback

Issue or PR is stalled on response from the author or a third party

  

needs docs

  

needs tests

  

not a bug

  

planned

  

pleroma_api

  

privacy

  

question

More information is needed

  

static_fe

  

triage

  

wontfix

This won't be fixed

No labels

approved, awaiting change

bug

configuration

documentation

duplicate

enhancement

extremely low priority

feature request

Fix it yourself

help wanted

invalid

mastodon_api

needs change/feedback

needs docs

needs tests

not a bug

planned

pleroma_api

privacy

question

static_fe

triage

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#927

No description provided.