fix some elixir 1.18 deprecation warnings #930

Merged
Oneric merged 2 commits from Oneric/akkoma:build_deprecation-warnings into develop 2025-05-16 09:39:25 +00:00
Owner

This deals with all but one warning generated from the main application; the remaining warning about an always matching cond is either a false positive or I’m misunderstanding what it wants to tell me.

Tests generate more warnings but since they only appear over time while running the tests and mingled with warnings from dependencies and log output it’s hard to get a comprehensive list of them.

This deals with all but one warning generated from the main application; the remaining warning about an always matching `cond` is either a false positive or I’m misunderstanding what it wants to tell me. Tests generate more warnings but since they only appear over time while running the tests and mingled with warnings from dependencies and log output it’s hard to get a comprehensive list of them.
Oneric added 2 commits 2025-05-15 21:48:33 +00:00
The replacement <!-- --> is available since
elixir 1.14.0 which matches our minimal version.
cosmetic: replace deprecated Tuple.append
All checks were successful
ci/woodpecker/pr/lint Pipeline was successful
ci/woodpecker/pr/test/2 Pipeline was successful
ci/woodpecker/pr/test/1 Pipeline was successful
ci/woodpecker/pr/build-arm64 Pipeline was successful
ci/woodpecker/pr/build-amd64 Pipeline was successful
ci/woodpecker/pr/docs Pipeline was successful
ci/woodpecker/pull_request_closed/lint Pipeline was successful
ci/woodpecker/pull_request_closed/test/1 Pipeline was successful
ci/woodpecker/pull_request_closed/test/2 Pipeline was successful
ci/woodpecker/pull_request_closed/build-arm64 Pipeline was successful
ci/woodpecker/pull_request_closed/build-amd64 Pipeline was successful
ci/woodpecker/pull_request_closed/docs Pipeline was successful
c749df62a1
Everytime a tuple is append a new one is allocated and all data copied
over. Keeping it a list until all entries are converted avoids this.
Oneric merged commit 3791b695f4 into develop 2025-05-16 09:39:25 +00:00
Oneric deleted branch build_deprecation-warnings 2025-05-16 09:39:25 +00:00
Sign in to join this conversation.
No description provided.