NormalizeMarkup scrub contentMap #932

Merged

Oneric merged 2 commits from Oneric/akkoma:normalize-markup_contentmap into develop 2025-06-07 18:27:27 +00:00

Conversation 1 Commits 2 Files changed 4 +37 -11

Oneric commented 2025-05-16 23:52:17 +00:00

Owner

Copy link

While contentMap values are currently unused, if this ever changes we first need to sanitise all existing entires in the database. Unsure whether we should do this sanitisation now, or only when/if those values actually start to get used (hoping we then didn’t forget about the lurking risk)

Fixes: #928

While `contentMap` values are currently unused, if this ever changes we first need to sanitise all existing entires in the database. Unsure whether we should do this sanitisation now, or only when/if those values actually start to get used (hoping we then didn’t forget about the lurking risk) Fixes: #928

Oneric added 2 commits 2025-05-16 23:52:18 +00:00

mrf/normalize_markup: also scrub contentMap ... 2eadc4b513

Only scrubbing "content" leads to differences between
"content" and "contentMap" eventhough the latter should
ideally match the former exactly for the primary language’s entry.

While ideally, for locally generated posts there should be no difference
between applying the scrubber or not, as it turns out automatically
generated attachment links didn't match the form expected by our default
scrubber.

Currently Akkoma never uses nor exposes the value of contentMap entries,
thus this oversight was harmless wrt to safety and at most pertubed
the language detection for our posts perfomed by remote servers.

Fixes: #928

common_api: make inserted attachment links scrubber-compliant 782a222efd

Oneric commented 2025-06-07 18:26:02 +00:00

Author

Owner

Copy link

Unsure whether we should do this sanitisation now, or only when/if those values actually start to get used (hoping we then didn’t forget about the lurking risk)

Since there might be more changes in the future; lets defer any retroactive processing for when we actually start to use the values

> Unsure whether we should do this sanitisation now, or only when/if those values actually start to get used (hoping we then didn’t forget about the lurking risk) Since there might be more changes in the future; lets defer any retroactive processing for when we actually start to use the values

Oneric merged commit d53a779c35 into develop 2025-06-07 18:27:27 +00:00

Oneric deleted branch normalize-markup_contentmap 2025-06-07 18:27:27 +00:00

Oneric referenced this pull request from a commit 2025-06-07 18:27:28 +00:00

Merge pull request 'NormalizeMarkup scrub contentMap' (#932) from Oneric/akkoma:normalize-markup_contentmap into develop

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

approved, awaiting change

  

bug

Something is not working

  

configuration

This requires config changes

  

documentation

This is about human-readable docs

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

extremely low priority

  

feature request

Something new?

  

Fix it yourself

Support has been attempted

  

help wanted

Need some help

  

invalid

Something is wrong

  

mastodon_api

  

needs change/feedback

Issue or PR is stalled on response from the author or a third party

  

needs docs

  

needs tests

  

not a bug

  

planned

  

pleroma_api

  

privacy

  

question

More information is needed

  

static_fe

  

triage

  

wontfix

This won't be fixed

No labels

approved, awaiting change

bug

configuration

documentation

duplicate

enhancement

extremely low priority

feature request

Fix it yourself

help wanted

invalid

mastodon_api

needs change/feedback

needs docs

needs tests

not a bug

planned

pleroma_api

privacy

question

static_fe

triage

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#932

No description provided.